| commit | f27798de50f97d857d59d13289ae527cc39de759 | [log] [tgz] |
|---|---|---|
| author | Ben Rohlfs <brohlfs@google.com> | Thu Jan 26 12:45:21 2023 +0100 |
| committer | Ben Rohlfs <brohlfs@google.com> | Thu Jan 26 17:09:49 2023 +0100 |
| tree | 121413937f68b7d9555d27353c02d6c03284b0dc | |
| parent | f22c5b2f816f5fc052ff722622859e6e204b886e [diff] |
Refactor gr-router_test The new test is 400 lines shorter, but simpler and produces more test coverage. It actually tests the pattern matching, which did not happen before. We are now consistently using these 3 methods: * checkRedirect * checkRedirectToLogin * checkUrlToState The names of the test are named directly after their `RoutePattern`. And most of the time we also copy the pattern as a comment into the test, so the tests are super easy to read and understand what they are supposed to be testing. We are only doing all this, so that we can follow-up with other refactorings. We need decent test coverage, so that we can be sure to not break anything. Also, moving routes into view model files will be much easier now, because in this new format the tests will be super easy to copy. Release-Notes: skip Change-Id: Ib3dc0362099ed56948bce0b7d382d3e8cd184681
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update && apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.