tree 7da25679f19c0e56fab33238131fa92a6320c05f
parent 78812bd5ed5c1b8f24a29c4a19cb25437aa45384
author Luca Milanesio <luca.milanesio@gmail.com> 1711058736 +0000
committer Luca Milanesio <luca.milanesio@gmail.com> 1711395025 +0000

Fix detection of invalid SSH key algorithm

Verify that the OpenSSH key algorithm matches the one
associated with the public key. Throw a new specific
InvalidKeyAlgorithmException if the two algorithms do not match.

This is a breaking change because invalid OpenSSH keys
have been tolerated since the very beginning, when Shawn introduced
the SSH support in Change 6610.
Attempting to store new invalid SSH keys would fail and result
an HTTP status 400 error as response to the add keys REST-API.

Make SshKeyCacheImpl tolerant to existing keys stored
in the accounts' profile, otherwise Gerrit may start flagging
keys that have been previously stored as invalid, resulting
in random authentication failures by existing users.

Existing invalid keys are reported in the error_log with the
associated exceptions and automatically fixed, removing the
invalid key from the accounts profile and adjusting the key
algorithm with the one associated with the public key.

Bug: Issue 330758152
Release-Notes: Breaking change: validate and reject SSH keys with invalid or mismatched algorithm
Change-Id: I83c89a786f70aa3b88744a70f10012415f45f284
(cherry picked from commit 6eac4fe62a6a081c5c9395f8874bdc49615eea0d)