| commit | 5ee738a07343316764db2873c140b533d03138d2 | [log] [tgz] |
|---|---|---|
| author | Frank Borden <frankborden@google.com> | Fri May 26 13:10:25 2023 +0200 |
| committer | Frank Borden <frankborden@google.com> | Fri May 26 14:56:04 2023 +0200 |
| tree | ab4304c453559211621ca564e681f45b608050c3 | |
| parent | 907d661b90cf374d284320a6d06f68b0406bed4c [diff] |
Wait a step before scrolling to settings section Navigating to https://gerrit-review.git.corp.google.com/settings/#Groups is broken due to not waiting for layout to settle before scrolling. Adding a tiny timeout before scrolling corrects this. Release-Notes: skip Google-Bug-Id: b/284338485 Change-Id: Iedab639c902f73dc1248a00c2e78215d9165bc1c
diff --git a/polygerrit-ui/app/elements/settings/gr-settings-view/gr-settings-view.ts b/polygerrit-ui/app/elements/settings/gr-settings-view/gr-settings-view.ts index 29203d0..d8361c3 100644 --- a/polygerrit-ui/app/elements/settings/gr-settings-view/gr-settings-view.ts +++ b/polygerrit-ui/app/elements/settings/gr-settings-view/gr-settings-view.ts
@@ -1124,7 +1124,7 @@ // Use shadowRoot for Polymer 2 const elem = (this.shadowRoot || document).querySelector(urlHash); if (elem) { - elem.scrollIntoView(); + setTimeout(() => elem.scrollIntoView(), 0); } } };