tree 8ea933c0650359824d6962717808a149545518b7
parent 06c86046fefc6555b98d81f3726dd664020aeb28
author David Ostrovsky <david@ostrovsky.org> 1573566563 -0800
committer Matthias Sohn <matthias.sohn@sap.com> 1575418884 +0100

Switch PatchListCache to using legacy cache backend

The implementation of PatchListLoader is using internally the
PatchListCache, to retrieve rebase related edits. The loading function
calling back into the cache violates the Caffeine interface contracts.
Guava could, theoretically, be more tolerant than Caffeine. This is due
to the hashtable design of locking and table expansion. However both are
explicit that the cache loader cannot write into the cache. Caffeine
will fail a fibonacci test, whereas Guava might pass. But that is
taking a lot of risk by relying on implementation details and violating
the contracts.

Switch to using legacy cache backend for PatchListCache, and consider
to switch using Caffeine cache backend and remove the legacy cache
support altogether, when the PatchListLoader is fixed to be recursion
free.

Bug: Issue 11900
Change-Id: I8f129dcf9b5574f024a600162d98aa381b3513cc
(cherry picked from commit 1d8f5ca43512ea7bc293520bfdbca23f1ad663fd)