| commit | 5ac9a97f2b0aab5a2fa59e2779aa0daec6733f00 | [log] [tgz] |
|---|---|---|
| author | David Ostrovsky <david@ostrovsky.org> | Tue Nov 12 05:49:23 2019 -0800 |
| committer | Matthias Sohn <matthias.sohn@sap.com> | Wed Dec 04 01:21:24 2019 +0100 |
| tree | 8ea933c0650359824d6962717808a149545518b7 | |
| parent | 06c86046fefc6555b98d81f3726dd664020aeb28 [diff] |
Switch PatchListCache to using legacy cache backend The implementation of PatchListLoader is using internally the PatchListCache, to retrieve rebase related edits. The loading function calling back into the cache violates the Caffeine interface contracts. Guava could, theoretically, be more tolerant than Caffeine. This is due to the hashtable design of locking and table expansion. However both are explicit that the cache loader cannot write into the cache. Caffeine will fail a fibonacci test, whereas Guava might pass. But that is taking a lot of risk by relying on implementation details and violating the contracts. Switch to using legacy cache backend for PatchListCache, and consider to switch using Caffeine cache backend and remove the legacy cache support altogether, when the PatchListLoader is fixed to be recursion free. Bug: Issue 11900 Change-Id: I8f129dcf9b5574f024a600162d98aa381b3513cc (cherry picked from commit 1d8f5ca43512ea7bc293520bfdbca23f1ad663fd)
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.