commit | 4c25dfcfd9d859c06e93a7c4c0b19085777caa3f | [log] [tgz] |
---|---|---|
author | Ole Rehmsen <oler@google.com> | Thu Mar 07 17:28:03 2019 +0100 |
committer | Ole Rehmsen <oler@google.com> | Fri Mar 15 13:30:01 2019 +0100 |
tree | 940be622fead628779091c3e215b7269363e0ec8 | |
parent | 7a82815691dac8490d912e504d80e8f85b3e77b2 [diff] |
Fix canceling diff processor/syntax layer The previous implementation has two bugs: 1) When calling process() and then cancel() before then continuation runs on a microtask, the ongoing work is not actually cancelled. This can happen at least in the case of loading highlightjs, but probably also in other cases. 2) When cancel() is called, the promise returned by promise() is currenty not rejected, potentially dangling there forever and leaking memory. Both are fixed in this change by canceling the promise when cancel() is called. Change-Id: Ieb0f1fcccd2cda3b2f9648347bc4e4311eb07a06
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.