tree 0cd4952d1078b9913095ae5961b44828075a701b
parent 8367b862f36529a487f12f9c0b45e94e38d0a9b8
author Edwin Kempin <ekempin@google.com> 1675337441 +0100
committer Edwin Kempin <ekempin@google.com> 1675338381 +0100

AccountResolver: Remove callerMayAssumeCandidatesAreVisible() method

Readers are often confused about what this method means. It means that
the searcher only returns results that are visible to the user, and
hence the caller doesn't need to do another visibility check.

Nowadays only the BySelf searcher makes use of this. Since users can
always see themselves, the visibility check on the result can be skipped
for the BySelf searcher.

Simplify this by removing the callerMayAssumeCandidatesAreVisible()
method and instead hard-code the exception for the BySelf search when
checking the visibility of the results. This should make the code easier
to read.

FWIW before change I90c2cd624 also the ByFullName and ByDefault searches
made use of skipping the visibility check by returning true from the
callerMayAssumeCandidatesAreVisible() method. This was because they
already checked the visibility during search by calling
enforceVisibility(true) on the InternalAccountQuery and hence the caller
didn't need to check the visibility again.

Release-Notes: skip
Signed-off-by: Edwin Kempin <ekempin@google.com>
Change-Id: I9b9967ae71dc75783a6b60510cff0950eeb7f97e