tree c9c1f0133a347e42ab64186cf86278c2adc70a18
parent 60fa2e122b8cb024edb171b2ac909c30f95b71e0
author Marija Savtchouk <mariasavtchouk@google.com> 1624021249 +0100
committer Marija Savtchouk <mariasavtchouk@google.com> 1624456623 +0100

Include impersonated user to email, sent on their behalf

Previously, if an email was sent from the user, they were only added to
the email if they had 'CC_ON_OWN_COMMENTS' email strategy ('Every
comment' in Settings on UI). Otherwise they would not be notified.

This is problematic in cases when the calling user is different from the
user that email is sent from. If the user is not included in the email
recipients in any other way (e.g. reviewer, owner), they would not be
notified at all. An example of such case is 'Submit' operation, executed
onBehalfOn[1].

With this change, a copy of an email will be always sent to the sender
in case of impersonation, unless email notifications are explicitly
disabled by the user. In cases, when the user is not being impersonated,
an email is sent according to notification preferences.

It is possible, that we can get rid of fromUserId entirely, and always
send an email from the identified user. I am suspicious that it might
break plugins.

[1]https://gerrit.googlesource.com/gerrit/+/bc69bccb/java/com/google/gerrit/server/restapi/change/Submit.java#177

Change-Id: Ida0c153103b16c4e9902d771c000078b5a752063