commit | 4bcd4fee77569772bc305641620264731a199711 | [log] [tgz] |
---|---|---|
author | Marija Savtchouk <mariasavtchouk@google.com> | Fri Jun 18 14:00:49 2021 +0100 |
committer | Marija Savtchouk <mariasavtchouk@google.com> | Wed Jun 23 14:57:03 2021 +0100 |
tree | c9c1f0133a347e42ab64186cf86278c2adc70a18 | |
parent | 60fa2e122b8cb024edb171b2ac909c30f95b71e0 [diff] |
Include impersonated user to email, sent on their behalf Previously, if an email was sent from the user, they were only added to the email if they had 'CC_ON_OWN_COMMENTS' email strategy ('Every comment' in Settings on UI). Otherwise they would not be notified. This is problematic in cases when the calling user is different from the user that email is sent from. If the user is not included in the email recipients in any other way (e.g. reviewer, owner), they would not be notified at all. An example of such case is 'Submit' operation, executed onBehalfOn[1]. With this change, a copy of an email will be always sent to the sender in case of impersonation, unless email notifications are explicitly disabled by the user. In cases, when the user is not being impersonated, an email is sent according to notification preferences. It is possible, that we can get rid of fromUserId entirely, and always send an email from the identified user. I am suspicious that it might break plugins. [1]https://gerrit.googlesource.com/gerrit/+/bc69bccb/java/com/google/gerrit/server/restapi/change/Submit.java#177 Change-Id: Ida0c153103b16c4e9902d771c000078b5a752063
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.