commit | 4bc6b67f14602fb029fc0fc4b0e121e3e9668491 | [log] [tgz] |
---|---|---|
author | Youssef Elghareeb <ghareeb@google.com> | Wed Oct 13 13:53:09 2021 +0200 |
committer | Youssef Elghareeb <ghareeb@google.com> | Wed Oct 13 16:04:57 2021 +0200 |
tree | 40738ec83c3d14ad9047b1c2757b9e381c3c1679 | |
parent | ad955984664803d82c06ce8f1c9323be39572287 [diff] |
Submit requirements: merge legacy and non-legacy results When experiment "enable_legacy_submit_requirements" is enabled, we convert legacy submit records to submit requirements and return them with ChangeInfo#submit_requirements. In order to allow for a smoother migration to new submit requirements, we can do this in two steps: 1) Add new submit requirements in project.config, track and monitor their evaluation and make sure they behave correctly. 2) Remove the legacy submit rules (prolog code, label functions). We would also like to allow creating submit requirements in project.config with the same name as legacy submit requirements. If this happens, we don't want the submit requirements API to return results with duplicate names. In this change, we detect this case and favour returning the project config's requirement if both results have the same fulfillment status (i.e. they both allow or disallow change submission). This change updates both code paths of open changes (in SubmitRequirmentsEvaluatorImpl) and closed changes (ChangeData). Change-Id: Id5db11e36aca7824d73cdfaf87f6d8f01dbc761b
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.