tree 4fee10a81b66d126629019f069327c22f5a7290c
parent 4bf16089679b6bb48c9b812e60510fe0f55e48b0
author Edwin Kempin <ekempin@google.com> 1565183878 +0200
committer Edwin Kempin <ekempin@google.com> 1565594469 +0200

TestSubmitRule/TestSubmitType: Require input rule

If the input doesn't contain a rule to test we now reject the request as
'400 Bad Request'.

In the documentation the rule field in RuleInput was already marked as
required and the behavior when the rule was not set was undocumented.
Hence changing this API should ok.

If the input didn't contain a rule the REST endpoints were "testing"
the rules that have been configured in the project. This functionality
seems to be unneeded. For the current revision this information is
available from ChangeInfo, and for other revisions this information is
not really interesting.

Unfortunately the TestSubmitRule.Get REST endpoint exposes the submit
type for an arbitrary revision. This is likely only needed for tests,
but since it's in the REST and extension API we cannot easily remove it.
Since the TestSubmitType.Get REST endpoint delegated to TestSubmitType
with no rule input it had to be rewritten. This fixes some issues with
this REST endpoints:

* error were not logged, because by delegating to TestSubmitType it was
  in "test" mode which suppressed errors
* '400 Bad Request' was returned if there was a rule error, but the rule
  was not provided by the caller, hence it was not a bad request,
  returning '409 Conflict' in this case is more appropriate

TestSubmitRule can now invoke PrologRule directly without going through
SubmitRuleEvaluator which makes the code a little simpler.

This is a preparation to cleanup the SubmitRule interface and remove the
SubmitRuleOptions arg from it.

Signed-off-by: Edwin Kempin <ekempin@google.com>
Change-Id: I728988722ff916f2cbe25b33c54d3a0c2aec1e28