commit 472396c79727e87c8126d2cb227b69de45bfacc0
author David Ostrovsky <david@ostrovsky.org> Wed Sep 20 09:02:21 2017 +0200
committer Dave Borowitz <dborowitz@google.com> Tue Oct 31 11:02:37 2017 -0400
tree 6a7b1744b61bf288cc2013a77631c63af9a05547
parent daf5cce936bc4b789072c1c5e760541c1705ed19

Move IndexVersionsTest to javatests top-level directory

Change-Id: Ibcfa6af2969b6d7e46631afa77b9ac19ce1ac207

gerrit-server/BUILD

diff --git a/gerrit-server/BUILD b/gerrit-server/BUILD
index 3e4dace..0434c15 100644
--- a/gerrit-server/BUILD
+++ b/gerrit-server/BUILD
@@ -275,18 +275,6 @@
     ],
 )
 
-junit_tests(
-    name = "testutil_test",
-    size = "small",
-    srcs = [
-        "src/test/java/com/google/gerrit/testutil/IndexVersionsTest.java",
-    ],
-    visibility = ["//visibility:public"],
-    deps = TESTUTIL_DEPS + [
-        "//java/com/google/gerrit/testing:gerrit-test-util",
-    ],
-)
-
 load("//tools/bzl:javadoc.bzl", "java_doc")
 
 java_doc(

java/com/google/gerrit/testing/IndexVersions.java

diff --git a/java/com/google/gerrit/testing/IndexVersions.java b/java/com/google/gerrit/testing/IndexVersions.java
index 876b8eb..fde93b2 100644
--- a/java/com/google/gerrit/testing/IndexVersions.java
+++ b/java/com/google/gerrit/testing/IndexVersions.java
@@ -31,9 +31,9 @@
 import org.eclipse.jgit.lib.Config;
 
 public class IndexVersions {
-  public static final String ALL = "all";
-  public static final String CURRENT = "current";
-  public static final String PREVIOUS = "previous";
+  static final String ALL = "all";
+  static final String CURRENT = "current";
+  static final String PREVIOUS = "previous";
 
   /**
    * Returns the index versions from {@link IndexVersions#get(SchemaDefinitions)} without the latest
@@ -85,8 +85,7 @@
   }
 
   @VisibleForTesting
-  public static <V> ImmutableList<Integer> get(
-      SchemaDefinitions<V> schemaDef, String name, String value) {
+  static <V> ImmutableList<Integer> get(SchemaDefinitions<V> schemaDef, String name, String value) {
     if (value != null) {
       value = value.trim();
     }

javatests/com/google/gerrit/testing/BUILD

diff --git a/javatests/com/google/gerrit/testing/BUILD b/javatests/com/google/gerrit/testing/BUILD
new file mode 100644
index 0000000..5829453
--- /dev/null
+++ b/javatests/com/google/gerrit/testing/BUILD
@@ -0,0 +1,12 @@
+load("//tools/bzl:junit.bzl", "junit_tests")
+
+junit_tests(
+    name = "testing_tests",
+    size = "small",
+    srcs = glob(["*.java"]),
+    deps = [
+        "//gerrit-server:server",
+        "//java/com/google/gerrit/testing:gerrit-test-util",
+        "//lib:truth",
+    ],
+)

javatests/com/google/gerrit/testing/IndexVersionsTest.java

diff --git a/gerrit-server/src/test/java/com/google/gerrit/testutil/IndexVersionsTest.java b/javatests/com/google/gerrit/testing/IndexVersionsTest.java
similarity index 96%
rename from gerrit-server/src/test/java/com/google/gerrit/testutil/IndexVersionsTest.java
rename to javatests/com/google/gerrit/testing/IndexVersionsTest.java
index 2c9a60f..36247f8 100644
--- a/gerrit-server/src/test/java/com/google/gerrit/testutil/IndexVersionsTest.java
+++ b/javatests/com/google/gerrit/testing/IndexVersionsTest.java
@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-package com.google.gerrit.testutil;
+package com.google.gerrit.testing;
 
 import static com.google.common.truth.Truth.assertThat;
 import static com.google.common.truth.TruthJUnit.assume;
@@ -21,8 +21,6 @@
 import static com.google.gerrit.testing.IndexVersions.PREVIOUS;
 
 import com.google.gerrit.server.index.change.ChangeSchemaDefinitions;
-import com.google.gerrit.testing.GerritBaseTests;
-import com.google.gerrit.testing.IndexVersions;
 import java.util.ArrayList;
 import java.util.List;
 import org.junit.Test;