tree ca62fb86a583c309e5a92965b1d5eae82e0e2595
parent d6aff75bbbca1ec71dc8e89cee93824a1a5c281b
author Sven Selberg <svense@axis.com> 1599836427 +0200
committer Luca Milanesio <luca.milanesio@gmail.com> 1600462564 +0000

Fix possible NPE when auto-closing changes

Before [1] all refs in existingRefs were guaranteed to be patchset refs,
whereas the refs taken from ReceivePackRefsCache are all refs in the
"refs/changes/*" namespace and these aren't guaranteed to be patchset
refs.

While walking the commits from new tip to previous tip to find open
changes that should be closed by the push, possible patchset-refs are
collected from ReceivePackRefsCache.
Check if the found refs actually are patchset-refs before attempting
to parse it into a Patchset.Id.

[1] https://gerrit-review.googlesource.com/c/gerrit/+/241932

Bug: Issue 13408
Change-Id: Ifafdbba79c436ced406914937ba259eccea7c84f