tree 5c493b5d7f6b9af24f4b4c8aea5843c7ad3732f1
parent bd2844f3ac6b83f1de486bcb2e7061a885ed0c16
author Dave Borowitz <dborowitz@google.com> 1544040448 -0800
committer Dave Borowitz <dborowitz@google.com> 1544040448 -0800

MetaDataUpdate: Make factories singletons

Typically factories are singletons, which means callers are tempted to
inject them directly instead of using providers, which would be the
correct thing to do in this case.

However, the only thing that is non-singleton-ish about them was that
they directly injected the @GerritPersonIdent; there's no need for this,
as they can inject a provider instead.

Change-Id: If7fbe2ccdc26a5cfc258efaf6495eb4ca7260b2d