commit | 434f490d36e9724349adfb571b73a7b180d1d6f3 | [log] [tgz] |
---|---|---|
author | Patrick Hiesel <hiesel@google.com> | Tue Jun 18 11:47:41 2019 +0200 |
committer | Patrick Hiesel <hiesel@google.com> | Tue Jun 18 14:59:32 2019 +0200 |
tree | 1cb3f03eb6e8392bdfbe8b506bdf75d2d40f9383 | |
parent | 83635c3710fd4c9ec0384b63a738b6d87b947f6b [diff] |
Fix ReceiveCommitsAdvertiseRefsHook, add docs and test coverage The tests for receive commits ref advertising were further away from reality than they should have been. In essence, they tested ReceiveCommitsAdvertiseRefsHook directly, which let room for bugs to creep in. Most prominently, we filter metadata for pushes. As metadata we see refs/changes/* and refs/cache-automerge/* (suboptimal naming is a concern not addressed by this commit). When the previous ref filter has already filtered out change refs then ReceiveCommitsAdvertiseRefsHook became a no-op and did not advertise the additional .haves it should because of a check for existence based on the previously advertised refs. This commit: - Fixes the aforementioned bug - Brings tests closer to reality by including the whole advertising chain, have JGit do the actual advertising and assert on that - Document the desired behavior Change-Id: I230e66eee5b94c6f62b0426e5c16849d993a1cfe
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.