commit | 404068c05c60ca5907ddb3a5b911ab913145b320 | [log] [tgz] |
---|---|---|
author | Gal Paikin <paiking@google.com> | Tue Sep 08 11:38:35 2020 +0300 |
committer | Gal Paikin <paiking@google.com> | Tue Sep 15 19:18:32 2020 +0300 |
tree | 6960a1bda3226bd29a9fbfc046613c252d06a2cc | |
parent | 83da3b1e25af5c85e0a1a75a9a5f91a3e1755849 [diff] |
Do not allow creations of comments with invalid inReplyTo We used to throw IllegalStateException until I06db2d8f removed them. Instead of returning the IllegalStateException, this change added BadRequestException in all places that can add inReplyTo to comments or drafts. Also fixed a test that allowed invalid inReplyTo when updating drafts. Also added a way to retrieve tags and unresolved from comments to the test API, since they are used here. As a follow-up change, the logic in PostReview, CreateDraftComment and PutDraftComment should actually be the same logic. Change-Id: I343425abd918a260f3fc71d5c26d18c42297465a
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.