commit 383a38abb4ed5682d9d9782efa2a5a42558187ca
author Tao Zhou <taoalpha@google.com> Tue Dec 03 08:56:25 2019 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Tue Dec 03 08:56:25 2019 +0000
tree 6b24d06283c9e35a7796cbe7fda7dd26e7bf5485
parent 35118e69b611124dff0d773becac8990ab6493d5
parent f534ca2e8a1a33251ee17229ec18a3b424e4429a

Merge "Fix undefined branch in create-destination-dialog"

polygerrit-ui/app/elements/change-list/gr-create-destination-dialog/gr-create-destination-dialog.js

diff --git a/polygerrit-ui/app/elements/change-list/gr-create-destination-dialog/gr-create-destination-dialog.js b/polygerrit-ui/app/elements/change-list/gr-create-destination-dialog/gr-create-destination-dialog.js
index 3652e70..cbc7bcd 100644
--- a/polygerrit-ui/app/elements/change-list/gr-create-destination-dialog/gr-create-destination-dialog.js
+++ b/polygerrit-ui/app/elements/change-list/gr-create-destination-dialog/gr-create-destination-dialog.js
@@ -50,9 +50,13 @@
       this.$.createOverlay.close();
     }
 
-    _pickerConfirm() {
+    _pickerConfirm(e) {
       this.$.createOverlay.close();
       const detail = {repo: this._repo, branch: this._branch};
+      // e is a 'confirm' event from gr-dialog. We want to fire a more detailed
+      // 'confirm' event here, so let's stop propagation of the bare event.
+      e.preventDefault();
+      e.stopPropagation();
       this.dispatchEvent(new CustomEvent('confirm', {detail, bubbles: false}));
     }