tree 1e6fbe772145ec7da991b1274ce76a3353306682
parent 5f44c5dc2190d3b11261b98e4d16add6e01c4eb3
author Alice Kober-Sotzek <aliceks@google.com> 1543930125 +0100
committer Alice Kober-Sotzek <aliceks@google.com> 1544022333 +0100

Send correct value for SuggestedReviewerInfo.confirm if limit is removed

According to our documentation, the user is never asked for confirmation
if addreviewer.maxWithoutConfirmation is set to 0. This is correctly
implemented in ReviewerAdder. PolyGerrit, though, never uses the logic
in ReviewerAdder but instead relies on the value of
SuggestedReviewerInfo.confirm for determining whether to show a
confirmation dialog.

As SuggestedReviewerInfo.confirm was filled with true even when
addreviewer.maxWithoutConfirmation was set to 0, this resulted in
PolyGerrit showing a confirmation dialog even though it shouldn't.
Fix this behavior by correctly filling SuggestedReviewerInfo.confirm.

Change-Id: I11e466f3fc260db4ff7167aa64c09148da314d02