commit | 2785ddfc1a93119f8bd0764c0c63c3367b5efcc4 | [log] [tgz] |
---|---|---|
author | Milutin Kristofic <milutin@google.com> | Thu Feb 13 14:18:47 2020 +0100 |
committer | Milutin Kristofic <milutin@google.com> | Fri Feb 14 15:12:18 2020 +0100 |
tree | c0e0dc23070b245d5964913d9bf7e2d962f10fa4 | |
parent | f4613afa5f413694a2f37ed4fee3a5d95b3160af [diff] |
Make blame annotation as link This enables to open change in new tab. Change-Id: I4ae547d8956f654703118f857b340ba525a62526
diff --git a/polygerrit-ui/app/elements/diff/gr-diff-builder/gr-diff-builder.js b/polygerrit-ui/app/elements/diff/gr-diff-builder/gr-diff-builder.js index 7a20dbb..8ce5c7a 100644 --- a/polygerrit-ui/app/elements/diff/gr-diff-builder/gr-diff-builder.js +++ b/polygerrit-ui/app/elements/diff/gr-diff-builder/gr-diff-builder.js
@@ -577,11 +577,9 @@ const blameNode = this._createElement('span', isStartOfRange ? 'startOfRange' : ''); - const shaNode = this._createElement('span', 'blameDate'); + const shaNode = this._createElement('a', 'blameDate'); shaNode.innerText = `${date}`; - shaNode.onclick = function() { - location.href = '/q/' + commit.id; - }; + shaNode.setAttribute('href', `/q/${commit.id}`); blameNode.appendChild(shaNode); const shortName = commit.author.split(' ')[0];
diff --git a/polygerrit-ui/app/elements/diff/gr-diff/gr-diff.html b/polygerrit-ui/app/elements/diff/gr-diff/gr-diff.html index 8380984..590537d 100644 --- a/polygerrit-ui/app/elements/diff/gr-diff/gr-diff.html +++ b/polygerrit-ui/app/elements/diff/gr-diff/gr-diff.html
@@ -281,7 +281,7 @@ td.blame .blameDate { font-family: var(--monospace-font-family); color: var(--link-color); - cursor: pointer; + text-decoration: none; } .full-width td.blame { overflow: hidden;