)]}'
{
  "commit": "246bb76ab55b6077f47069e4ad41979f81b6d1af",
  "tree": "41343efb61a87c06e9b53fcddc30bd196cfb1af4",
  "parents": [
    "95d1d88589b32b54ea473708bd590608917d3b5f"
  ],
  "author": {
    "name": "Nasser Grainawi",
    "email": "nasser.grainawi@linaro.org",
    "time": "Tue Apr 09 13:18:10 2024 -0600"
  },
  "committer": {
    "name": "Nasser Grainawi",
    "email": "nasser.grainawi@linaro.org",
    "time": "Tue Apr 09 13:18:10 2024 -0600"
  },
  "message": "Avoid work in Optional.orElse() calls\n\nAny code inside the orElse() will always be called, even if the result\nisn\u0027t used because the optional is present. This is wasteful at a\nminimum and can be actively harmful (as seen in [1]) because of side\neffects or performance impacts. Fix that by replacing all orElse() calls\nthat create new instances or do non-constant work with either a call to\norElseGet() or an if statement.\n\nIt\u0027s possible this will result in performance improvements, but I didn\u0027t\nattempt to measure any, so I\u0027m not including a release note.\n\nIt would be nice if there were an ErrorProne checker for this, but one\ndoesn\u0027t exist yet.\n\n[1] https://gerrit-review.googlesource.com/c/gerrit/+/417915/comment/0ea287cd_bfecb7f2/\n\nChange-Id: Icab4115998fb4f3787ca74c0890949cb3ce5c6a6\nRelease-Notes: skip\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "a9ad3f237b68cedfff2b4b4f7c8e454e3f98cee5",
      "old_mode": 33188,
      "old_path": "java/com/google/gerrit/acceptance/GerritServer.java",
      "new_id": "3bbc74ee131cf722013ef4e5bebe54750c5d3bf2",
      "new_mode": 33188,
      "new_path": "java/com/google/gerrit/acceptance/GerritServer.java"
    },
    {
      "type": "modify",
      "old_id": "dcf1158e149c411da30c40b12028e77dc106f318",
      "old_mode": 33188,
      "old_path": "java/com/google/gerrit/acceptance/testsuite/group/GroupOperationsImpl.java",
      "new_id": "a37c2babbeee1c67b96ee185074a63187b6204c1",
      "new_mode": 33188,
      "new_path": "java/com/google/gerrit/acceptance/testsuite/group/GroupOperationsImpl.java"
    },
    {
      "type": "modify",
      "old_id": "deeb84309f00c5768215c1aa1cb6b3d37b37d2bc",
      "old_mode": 33188,
      "old_path": "java/com/google/gerrit/acceptance/testsuite/project/ProjectOperationsImpl.java",
      "new_id": "1014a0f7ad013b9e8d16a262eca89dfda3a17e8f",
      "new_mode": 33188,
      "new_path": "java/com/google/gerrit/acceptance/testsuite/project/ProjectOperationsImpl.java"
    },
    {
      "type": "modify",
      "old_id": "15dcf42e0e7d27d4ef81a4fb3e79e07415c9093d",
      "old_mode": 33188,
      "old_path": "java/com/google/gerrit/httpd/raw/StaticModule.java",
      "new_id": "1e76f215e904a204324e3a25d12c93b211b24bb2",
      "new_mode": 33188,
      "new_path": "java/com/google/gerrit/httpd/raw/StaticModule.java"
    },
    {
      "type": "modify",
      "old_id": "f41b1e3c3dc3478e830541bd36f42f1de0097aff",
      "old_mode": 33188,
      "old_path": "java/com/google/gerrit/server/DeadlineChecker.java",
      "new_id": "9b7ffe6c3f0b21d6cc534dab6647f45ea30b1e8e",
      "new_mode": 33188,
      "new_path": "java/com/google/gerrit/server/DeadlineChecker.java"
    },
    {
      "type": "modify",
      "old_id": "66a36f6595d0b452356e65dd8545188c29c3d01c",
      "old_mode": 33188,
      "old_path": "java/com/google/gerrit/server/account/AccountCacheImpl.java",
      "new_id": "d306ad0e92c49b184c0512a577d776faea197bff",
      "new_mode": 33188,
      "new_path": "java/com/google/gerrit/server/account/AccountCacheImpl.java"
    },
    {
      "type": "modify",
      "old_id": "891a467577ea1fa91e9feef2b8b47e30cc3f2b28",
      "old_mode": 33188,
      "old_path": "java/com/google/gerrit/server/account/AccountManager.java",
      "new_id": "5edba08eaa041b24a23fc3927020e1e5c507bfad",
      "new_mode": 33188,
      "new_path": "java/com/google/gerrit/server/account/AccountManager.java"
    },
    {
      "type": "modify",
      "old_id": "1199be5657a821fee94ade53257760fda00b3eca",
      "old_mode": 33188,
      "old_path": "java/com/google/gerrit/server/change/DeleteReviewerOp.java",
      "new_id": "84ea730c570ba38cafdaded0b7baab2a07f58558",
      "new_mode": 33188,
      "new_path": "java/com/google/gerrit/server/change/DeleteReviewerOp.java"
    },
    {
      "type": "modify",
      "old_id": "4f6094e6854a1f5bf5c5df62e7f56f15b219f3e3",
      "old_mode": 33188,
      "old_path": "java/com/google/gerrit/server/git/DefaultChangeReportFormatter.java",
      "new_id": "58c3eb10b9ebf05be4e9e19faef34019be17d096",
      "new_mode": 33188,
      "new_path": "java/com/google/gerrit/server/git/DefaultChangeReportFormatter.java"
    },
    {
      "type": "modify",
      "old_id": "0f5e3bc1baee4241ede1e813b8ccda961bd17d8f",
      "old_mode": 33188,
      "old_path": "java/com/google/gerrit/server/git/receive/ReceiveCommits.java",
      "new_id": "dbe0fa8857b396e218100698774008bdf86d050a",
      "new_mode": 33188,
      "new_path": "java/com/google/gerrit/server/git/receive/ReceiveCommits.java"
    },
    {
      "type": "modify",
      "old_id": "235ca4f613f8867c8903153512973b2127bf9474",
      "old_mode": 33188,
      "old_path": "java/com/google/gerrit/server/group/db/AuditLogFormatter.java",
      "new_id": "3ba087e3156285ce47d0e1dabd5312a056975da5",
      "new_mode": 33188,
      "new_path": "java/com/google/gerrit/server/group/db/AuditLogFormatter.java"
    },
    {
      "type": "modify",
      "old_id": "7a8180bd13e08e80491723c5cce071e505f9e0b5",
      "old_mode": 33188,
      "old_path": "java/com/google/gerrit/server/patch/PatchFile.java",
      "new_id": "c3a6807fac8f63d339be78ce8b92d750f1b3e19a",
      "new_mode": 33188,
      "new_path": "java/com/google/gerrit/server/patch/PatchFile.java"
    },
    {
      "type": "modify",
      "old_id": "342c2bcc06e80b9218b51066b75bb5200534edec",
      "old_mode": 33188,
      "old_path": "java/com/google/gerrit/server/project/Reachable.java",
      "new_id": "c935adf0790eacb20d73f0d7fe49101feff0d392",
      "new_mode": 33188,
      "new_path": "java/com/google/gerrit/server/project/Reachable.java"
    },
    {
      "type": "modify",
      "old_id": "bea5eaad50dbb222dc2de76a9441a1af42429234",
      "old_mode": 33188,
      "old_path": "javatests/com/google/gerrit/server/group/db/AbstractGroupTest.java",
      "new_id": "a9ceddb076fc8b50e93eb125a2ed347539db980f",
      "new_mode": 33188,
      "new_path": "javatests/com/google/gerrit/server/group/db/AbstractGroupTest.java"
    }
  ]
}