tree fe4012dacc8db14cc54cdf5cd3653d98e1381c42
parent cb72e26daf73608f0c59612d865f5a2f97a70166
author Dave Borowitz <dborowitz@google.com> 1415817042 -0800
committer Dave Borowitz <dborowitz@google.com> 1415817302 -0800

Simplify ChangeIndex by removing delete(ChangeData)

Since indexing is generally done after any modification operations,
using a deleted ChangeData when indexing a deleted change is just
asking for trouble; most ChangeData methods (reasonably) assume that
the change exists. Instead, just use the form of the method that
passes in the ID.

Change the method that takes an integer ID to take a Change.Id object.
In almost all cases we already have one of these handy, and this is
more consistent with public interfaces elsewhere in Gerrit.

A fortunate side effect is that async deletes should happen slightly
faster, since we no longer need to open a DB connection and produce a
ChangeData in the delete codepath.

Change-Id: I353522b52188de11353ca26a7ba90a2ca462e404