tree 2b6f3d74d2e8d5c270463f2a06822c2fb7af979e
parent 5044de0330b8ed421fca21c8ff61560fca020657
author David Ostrovsky <david@ostrovsky.org> 1571001480 +0200
committer David Ostrovsky <david@ostrovsky.org> 1571042355 +0200

Rewrite OS bean provider to avoid using reflection

Try to cast the OperatingSystemMVBean to unix instance and in success
case use that instance directly instead of reflection based approach.

Given that 99% of gerrit instances are used on linux based systems
in production, we can avoid reflection access altogether and thus
administrators wouldn't need to pass:

  --add-opens=jdk.management/com.sun.management.internal=ALL-UNNAMED

option on newer Java versions.

Test Plan (on *nix system):

1. Build gerrit to produce Java lanuage level 11:

  $ bazel build --host_javabase=@bazel_tools//tools/jdk:remote_jdk11 \
    --javabase=@bazel_tools//tools/jdk:remote_jdk11 \
    --host_java_toolchain=@bazel_tools//tools/jdk:toolchain_java11 \
    --java_toolchain=@bazel_tools//tools/jdk:toolchain_java11 \
    :release

2. Init new gerrit site
3. Run gerrit site with Java 11
4. Confirm that it can be started and works as expected without passing
  --add-opens=jdk.management/com.sun.management.internal=ALL-UNNAMED
option.

Bug: Issue 7843
Change-Id: I712d3fab05b267fa4ab5b3ba17247287aebebcb6