tree 228f90607800f14e8d87fb940fc330ac07e9e5d8
parent 082a716b8e9ee3a578648146f03429e5349d78c0
author Edwin Kempin <ekempin@google.com> 1668427367 +0100
committer Edwin Kempin <ekempin@google.com> 1668427984 +0100

Do not require trailing slash for requests on root collections

Often users are confused why 'GET /changes/' works, but 'GET /changes'
doesn't. We should just allow both. This is consistent with requests on
sub-collections where a trailing slash is not required (e.g.  'GET
/changes/<CHANGE-ID>/reviewers/' and 'GET
/changes/<CHANGE-ID>/reviewers' both work).

Fix this by registering the servlets for the root collections twice,
once for '^/(?:a/)?<ROOT-COLLECTION>/(.*)$' and once for
'^/(?:a/)?<ROOT-COLLECTION>$'. That's a bit hacky, but since we add new
root collections rarely it should be fine. Trying to register the
servlets for the root collections on a more smart regexp, like
'^/(?:a/)?<ROOT-COLLECTION>(/(.*))?$' doesn't work as the multiple
matching groups confuse the parsing of the path which is done in the
servlet library.

Release-Notes: Do not require trailing slash for requests on root collections
Signed-off-by: Edwin Kempin <ekempin@google.com>
Change-Id: Ib362c9c1f19d9c12eb25ddfcd1ea8466cab2802c
Bug: Google b/258856716