commit 1e51293cdfbeba62f5a48d4de4c2e7b192bf5ee3
author Han-Wen Nienhuys <hanwen@google.com> Tue Jan 12 20:13:51 2021 +0100
committer Han-Wen Nienhuys <hanwen@google.com> Wed Jan 13 12:48:46 2021 +0100
tree 0832db107954dc796e12458c3e62012712c092ae
parent 0774f5d75c2847fd97229feeb6970af20b6d60a5

CommitsCollection: document parseBody() call

Explanation transplanted from commit 68bb905 ("Parse body when
creating CommitResource")

Change-Id: I2da49b8bec992b1d897c85c9d7cda8dadd4dddce

java/com/google/gerrit/server/restapi/project/CommitsCollection.java

diff --git a/java/com/google/gerrit/server/restapi/project/CommitsCollection.java b/java/com/google/gerrit/server/restapi/project/CommitsCollection.java
index 21d7f0b..9e0661c 100644
--- a/java/com/google/gerrit/server/restapi/project/CommitsCollection.java
+++ b/java/com/google/gerrit/server/restapi/project/CommitsCollection.java
@@ -93,10 +93,12 @@
     try (Repository repo = repoManager.openRepository(parent.getNameKey());
         RevWalk rw = new RevWalk(repo)) {
       RevCommit commit = rw.parseCommit(objectId);
-      rw.parseBody(commit);
       if (!canRead(parent.getProjectState(), repo, commit)) {
         throw new ResourceNotFoundException(id);
       }
+      // GetCommit depends on the body of both the commit and parent being parsed, to get the
+      // subject.
+      rw.parseBody(commit);
       for (int i = 0; i < commit.getParentCount(); i++) {
         rw.parseBody(rw.parseCommit(commit.getParent(i)));
       }