Google Git
Sign in
gerrit / gerrit / 162dfd460a78dd66acb276b9e9c7b0d54279b3dc
commit162dfd460a78dd66acb276b9e9c7b0d54279b3dc[log] [tgz]
authorYoussef Elghareeb <ghareeb@google.com>Wed Jun 23 16:39:48 2021 +0200
committerYoussef Elghareeb <ghareeb@google.com>Wed Jun 23 17:13:50 2021 +0200
treebe02094f1da00acc4f894b17a5b0b385c6ab7271
parent9ed4c4043a0f8b80a6629792a499c3b72bec08a8 [diff]
Diff against root commits: use ObjectId#zeroId instead of EMPTY_TREE_ID

We used to reserve the special EMPTY_TREE_ID
4b825dc642cb6eb9a060e54bf8d69288fbee4904 for the
FileDiffCacheKey#oldCommit and the GitFileDiffCacheKey#oldTree. We also
use the same thing for the ModifiedFilesCache and GitModifiedFilesCache.
Callers pass this value to request the diff for a root commit. The cache
loader used to pass this value further to DiffFormatter#scan (in JGit)
to perform the scan.

Some repositories may not have the EMPTY_TREE_ID as a valid git object.
This resulted in a MissingObjectException in DiffFormatter#scan.

Here we change the following:
1) Use ObjectId#zeroId instead of EMPTY_TREE_ID in the cache keys to
signal requesting a diff against an added tree (i.e. root commit).
2) Change the handling in the loader by passing a null value to the old
tree parameter in DiffFormatter#scan. The method documents accepting
null values to perform this kind of diff. Check [1].

[1] https://git.eclipse.org/r/plugins/gitiles/jgit/jgit/+/f598e69529e0a1864e8224265ed82326f2a296f5/org.eclipse.jgit/src/org/eclipse/jgit/diff/DiffFormatter.java#426

Change-Id: I004dcf991f600052054aa167f24a925f1994eab3
11 files changed
tree: be02094f1da00acc4f894b17a5b0b385c6ab7271
  1. .settings/
  2. .ts-out/
  3. antlr3/
  4. contrib/
  5. Documentation/
  6. e2e-tests/
  7. java/
  8. javatests/
  9. lib/
  10. modules/
  11. plugins/
  12. polygerrit-ui/
  13. prolog/
  14. prologtests/
  15. proto/
  16. resources/
  17. tools/
  18. webapp/
  19. polymer-bridges
  20. .bazelignore
  21. .bazelproject
  22. .bazelrc
  23. .bazelversion
  24. .editorconfig
  25. .git-blame-ignore-revs
  26. .gitignore
  27. .gitmodules
  28. .gitreview
  29. .mailmap
  30. .pydevproject
  31. .zuul.yaml
  32. BUILD
  33. COPYING
  34. INSTALL
  35. Jenkinsfile
  36. package.json
  37. README.md
  38. SUBMITTING_PATCHES
  39. version.bzl
  40. WORKSPACE
  41. yarn.lock
README.md

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Build Status Maven Central

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.

Reporting bugs

Please report bugs on the issue tracker.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Note that we do not accept Pull Requests via the Github mirror.

Getting in contact

The Developer Mailing list is repo-discuss on Google Groups.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Bazel and run the following:

    git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
    cd gerrit && bazel build release

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update & apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

On Fedora run:

    dnf clean all && dnf install gerrit-<version>[-<release>]

Use pre-built Gerrit images on Docker

Docker images of Gerrit are available on DockerHub

To run a CentOS 8 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8

To run a Ubuntu 20.04 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.