tree 133618fa6b777f3174baae4a6d849801779c6ed1
parent 88ab2404c2ae42ad8c30546b4565bb66b4cb1bf8
author Marija Savtchouk <mariasavtchouk@google.com> 1633098219 +0100
committer Marija Savtchouk <mariasavtchouk@google.com> 1633346931 +0000

Do not check if user can read all refs with -b option

Currently, with -b option, ListRefsfirst first checks if all refs are
visible to the user [1].
This is done by checking permission for each ref pattern that has 'read' permission block
block in project.config[2][3]
Then 'read' permissions for each of the requested refs are checked[4]

This is problematic if project.config has a large number of 'read' blocks.
Since it is expected that the number of branches in the request is small, we can
skip the check that all refs are visible and only check requested branches.

[1]https://gerrit.googlesource.com/gerrit/+/refs/heads/master/java/com/google/gerrit/server/restapi/project/ListProjects.java#586
[2]https://gerrit.googlesource.com/gerrit/+/refs/heads/master/java/com/google/gerrit/server/permissions/ProjectControl.java#442
[3]https://gerrit.googlesource.com/gerrit/+/refs/heads/master/java/com/google/gerrit/server/permissions/ProjectControl.java#293
[4]https://gerrit.googlesource.com/gerrit/+/refs/heads/master/java/com/google/gerrit/server/restapi/project/ListProjects.java#723

Google-bug-Id: b/201425838
Change-Id: Ideb4cb41f106a2b1a58da777371d687dc1a5c65e