commit 14b50f705485a8236b2870246e8d57fd5899be81
author Patrick Hiesel <hiesel@google.com> Mon Aug 02 08:17:32 2021 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Mon Aug 02 08:17:32 2021 +0000
tree 18aa9a96d605cdf3b31b4b349d20f2d9edac2288
parent f56f791b9cb1e62f31a02ee8ecf00c7589b1e668
parent 018b556828975688cf0c8c79b7c576c01e5a5447

Merge changes I0f614cbc,Icc44ba80

* changes:
  MultiProgressMonitor: Rename write flag
  RestApiServlet: Factor out methods to compute cancellation status and message

java/com/google/gerrit/httpd/restapi/RestApiServlet.java

diff --git a/java/com/google/gerrit/httpd/restapi/RestApiServlet.java b/java/com/google/gerrit/httpd/restapi/RestApiServlet.java
index 92e542a..375aa54 100644
--- a/java/com/google/gerrit/httpd/restapi/RestApiServlet.java
+++ b/java/com/google/gerrit/httpd/restapi/RestApiServlet.java
@@ -114,6 +114,7 @@
 import com.google.gerrit.server.audit.ExtendedHttpAuditEvent;
 import com.google.gerrit.server.cache.PerThreadCache;
 import com.google.gerrit.server.cancellation.RequestCancelledException;
+import com.google.gerrit.server.cancellation.RequestStateProvider;
 import com.google.gerrit.server.change.ChangeFinder;
 import com.google.gerrit.server.change.RevisionResource;
 import com.google.gerrit.server.config.GerritServerConfig;
@@ -718,24 +719,11 @@
         Optional<RequestCancelledException> requestCancelledException =
             RequestCancelledException.getFromCausalChain(e);
         if (requestCancelledException.isPresent()) {
-          switch (requestCancelledException.get().getCancellationReason()) {
-            case CLIENT_CLOSED_REQUEST:
-              statusCode = SC_CLIENT_CLOSED_REQUEST;
-              break;
-            case CLIENT_PROVIDED_DEADLINE_EXCEEDED:
-            case SERVER_DEADLINE_EXCEEDED:
-              statusCode = SC_REQUEST_TIMEOUT;
-              break;
-          }
-
-          StringBuilder msg =
-              new StringBuilder(requestCancelledException.get().formatCancellationReason());
-          if (requestCancelledException.get().getCancellationMessage().isPresent()) {
-            msg.append("\n\n");
-            msg.append(requestCancelledException.get().getCancellationMessage().get());
-          }
-
-          responseBytes = replyError(req, res, statusCode, msg.toString(), e);
+          statusCode =
+              getCancellationStatusCode(requestCancelledException.get().getCancellationReason());
+          responseBytes =
+              replyError(
+                  req, res, statusCode, getCancellationMessage(requestCancelledException.get()), e);
         } else {
           statusCode = SC_INTERNAL_SERVER_ERROR;
 
@@ -1969,6 +1957,28 @@
     return replyBinaryResult(req, res, BinaryResult.create(text).setContentType(PLAIN_TEXT));
   }
 
+  private static int getCancellationStatusCode(RequestStateProvider.Reason cancellationReason) {
+    switch (cancellationReason) {
+      case CLIENT_CLOSED_REQUEST:
+        return SC_CLIENT_CLOSED_REQUEST;
+      case CLIENT_PROVIDED_DEADLINE_EXCEEDED:
+      case SERVER_DEADLINE_EXCEEDED:
+        return SC_REQUEST_TIMEOUT;
+    }
+    logger.atSevere().log("Unexpected cancellation reason: %s", cancellationReason);
+    return SC_INTERNAL_SERVER_ERROR;
+  }
+
+  private static String getCancellationMessage(
+      RequestCancelledException requestCancelledException) {
+    StringBuilder msg = new StringBuilder(requestCancelledException.formatCancellationReason());
+    if (requestCancelledException.getCancellationMessage().isPresent()) {
+      msg.append("\n\n");
+      msg.append(requestCancelledException.getCancellationMessage().get());
+    }
+    return msg.toString();
+  }
+
   private static boolean acceptsGzip(HttpServletRequest req) {
     if (req != null) {
       String accepts = req.getHeader(HttpHeaders.ACCEPT_ENCODING);

java/com/google/gerrit/server/git/MultiProgressMonitor.java

diff --git a/java/com/google/gerrit/server/git/MultiProgressMonitor.java b/java/com/google/gerrit/server/git/MultiProgressMonitor.java
index 2d854a5..1122551 100644
--- a/java/com/google/gerrit/server/git/MultiProgressMonitor.java
+++ b/java/com/google/gerrit/server/git/MultiProgressMonitor.java
@@ -131,7 +131,7 @@
   private int spinnerIndex;
   private char spinnerState = NO_SPINNER;
   private boolean done;
-  private boolean write = true;
+  private boolean clientDisconnected;
 
   private final long maxIntervalNanos;
 
@@ -343,14 +343,14 @@
   }
 
   private void send(StringBuilder s) {
-    if (write) {
+    if (!clientDisconnected) {
       try {
         out.write(Constants.encode(s.toString()));
         out.flush();
       } catch (IOException e) {
         logger.atWarning().withCause(e).log(
             "Sending progress to client failed. Stop sending updates for task %s", taskName);
-        write = false;
+        clientDisconnected = true;
       }
     }
   }