tree d26686e6f3bf1a5dfbc1f5c0d381e2abbf601ff1
parent c07c18a68752aeba528cff6f33a9b87417c1b318
author Edwin Kempin <ekempin@google.com> 1488186819 +0100
committer Edwin Kempin <ekempin@google.com> 1490693290 +0200

AccountByEmailCacheImpl: Don't use account index to find accounts by email

Instead rather get accounts by email from either the database (if
external IDs are read from ReviewDb) or from the ExternalIdCache (if
external IDs are read from NoteDb).

For NoteDb Using the in-memory cache is faster than doing the lookup via
the account index.

To support querying accounts by email from ReviewDb the
account_external_ids_byEmail index is added back temporarily. The
follow-up change will drop the account_external_ids table completely and
hence this index will be gone again.

The ReviewDb method to query accounts by email is also needed to perform
the external ID migration on the https://*-review.googlesource.com
Gerrit servers at Google.

Change-Id: Ib9961060676c422b75c83b0cbc23c0e585813b16
Signed-off-by: Edwin Kempin <ekempin@google.com>