Rename ReviewerAdditionList to ReviewerModificationList
This change doesn't perform any logical changes, but a follow-up change
can extend this class to also support deletions.
Change-Id: Ie0161bc15835a2acb24091880cc1b8a1523bf86a
diff --git a/java/com/google/gerrit/server/change/ChangeInserter.java b/java/com/google/gerrit/server/change/ChangeInserter.java
index 16c8a6d..22bbd82 100644
--- a/java/com/google/gerrit/server/change/ChangeInserter.java
+++ b/java/com/google/gerrit/server/change/ChangeInserter.java
@@ -51,8 +51,8 @@
import com.google.gerrit.server.ChangeUtil;
import com.google.gerrit.server.PatchSetUtil;
import com.google.gerrit.server.change.ReviewerModifier.InternalReviewerInput;
-import com.google.gerrit.server.change.ReviewerModifier.ReviewerAdditionList;
import com.google.gerrit.server.change.ReviewerModifier.ReviewerModification;
+import com.google.gerrit.server.change.ReviewerModifier.ReviewerModificationList;
import com.google.gerrit.server.config.SendEmailExecutor;
import com.google.gerrit.server.config.UrlFormatter;
import com.google.gerrit.server.events.CommitReceivedEvent;
@@ -149,7 +149,7 @@
private PatchSet patchSet;
private String pushCert;
private ProjectState projectState;
- private ReviewerAdditionList reviewerAdditions;
+ private ReviewerModificationList reviewerAdditions;
@Inject
ChangeInserter(
diff --git a/java/com/google/gerrit/server/change/ReviewerModifier.java b/java/com/google/gerrit/server/change/ReviewerModifier.java
index 653209e..b45b6a9 100644
--- a/java/com/google/gerrit/server/change/ReviewerModifier.java
+++ b/java/com/google/gerrit/server/change/ReviewerModifier.java
@@ -520,7 +520,7 @@
return !SystemGroupBackend.isSystemGroup(groupUUID);
}
- public ReviewerAdditionList prepare(
+ public ReviewerModificationList prepare(
ChangeNotes notes,
CurrentUser user,
Iterable<? extends ReviewerInput> inputs,
@@ -549,7 +549,7 @@
}
additions.add(addition);
}
- return new ReviewerAdditionList(additions);
+ return new ReviewerModificationList(additions);
}
// TODO(dborowitz): This class works, but ultimately feels wrong. It seems like an op but isn't
@@ -557,10 +557,10 @@
// could make this class an op, but we would still have AddReviewersOp. Better would probably be
// to design a single op that supports combining multiple ReviewerInputs together. That would
// probably also subsume the Addition class itself, which would be a good thing.
- public static class ReviewerAdditionList {
+ public static class ReviewerModificationList {
private final ImmutableList<ReviewerModification> modifications;
- private ReviewerAdditionList(List<ReviewerModification> modifications) {
+ private ReviewerModificationList(List<ReviewerModification> modifications) {
this.modifications = ImmutableList.copyOf(modifications);
}
diff --git a/java/com/google/gerrit/server/git/receive/ReplaceOp.java b/java/com/google/gerrit/server/git/receive/ReplaceOp.java
index af84828..6e4f9da 100644
--- a/java/com/google/gerrit/server/git/receive/ReplaceOp.java
+++ b/java/com/google/gerrit/server/git/receive/ReplaceOp.java
@@ -54,8 +54,8 @@
import com.google.gerrit.server.change.NotifyResolver;
import com.google.gerrit.server.change.ReviewerModifier;
import com.google.gerrit.server.change.ReviewerModifier.InternalReviewerInput;
-import com.google.gerrit.server.change.ReviewerModifier.ReviewerAdditionList;
import com.google.gerrit.server.change.ReviewerModifier.ReviewerModification;
+import com.google.gerrit.server.change.ReviewerModifier.ReviewerModificationList;
import com.google.gerrit.server.config.SendEmailExecutor;
import com.google.gerrit.server.config.UrlFormatter;
import com.google.gerrit.server.extensions.events.CommentAdded;
@@ -159,7 +159,7 @@
private String rejectMessage;
private MergedByPushOp mergedByPushOp;
private RequestScopePropagator requestScopePropagator;
- private ReviewerAdditionList reviewerAdditions;
+ private ReviewerModificationList reviewerAdditions;
private MailRecipients oldRecipients;
@Inject