commit | 074a019afa7e7a7dd2fc947dfad385b917b01f83 | [log] [tgz] |
---|---|---|
author | Edwin Kempin <ekempin@google.com> | Fri Jan 13 10:28:32 2023 +0100 |
committer | Edwin Kempin <ekempin@google.com> | Fri Jan 13 11:04:54 2023 +0000 |
tree | 95d150c772c53cca0354e939793b0cacb35fb4f8 | |
parent | a16efe1a16ce8718496446f45e6ccf7e4b133262 [diff] |
Fix overriding impersonated votes If there is an impersonated vote for a user A (real user B) and A votes on the change the new non-impersonated vote of user A overrides the impersonated vote for a user A (real user B). However this only worked if the voting values were different (e.g. the impersonated vote was Code-Review+1 and the non-impersonated vote was Code-Review-1). If the voting value was the same (e.g. the impersonated vote was Code-Review+1 and the non-impersonated vote was also Code-Review+1) Gerrit wrongly assumed that the voting was a no-op (since the voting values were the same). Fix this by taking the realUser into account as well when checking if a vote is a no-op. This also fixes overriding an impersonated vote (e.g. for user A by real user B) with another impersonated vote (e.g. for user A by real user C). Also here so far this only worked if the voting values were different. Release-Notes: Fixed overriding impersonated votes Signed-off-by: Edwin Kempin <ekempin@google.com> Change-Id: Ic1135eacf3815f52994195783d4c86cc79feed04
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update && apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.