)]}' { "commit": "db4737001164e98c8fd8323abe0deeac3b7e9fbf", "tree": "4e5eaf8eb0e2be0e40ffc0fc3020eb723f50ac56", "parents": [ "024e5aa31d32c11e0fa7c73028e052bd1b9a157b" ], "author": { "name": "Dave Borowitz", "email": "dborowitz@google.com", "time": "Tue Jan 15 08:57:49 2019 -0800" }, "committer": { "name": "Dave Borowitz", "email": "dborowitz@google.com", "time": "Tue Jan 15 13:57:43 2019 -0800" }, "message": "Consistently don\u0027t import Id/Key/NameKey/Entry types\n\nThese are often ambiguous without their containing class, not to mention\nused inconsistently within single class files. Implement a consistent\npolicy.\n\nAfter this change there are exactly two remaining:\n\n$ find . -name \\*.java | sort | xargs pcregrep \u0027^import.*\\.[A-Z][^.]*\\.(NameKey|Key|Id|Entry);\u0027\n./java/com/google/gerrit/httpd/CacheBasedWebSession.java:import com.google.gerrit.httpd.WebSessionManager.Key;\n./javatests/com/google/gerrit/server/change/ChangeKindCacheImplTest.java:import com.google.gerrit.server.change.ChangeKindCacheImpl.Key;\n\nThese are corner cases of a specific cache implementation where the Key\ntype is less ambiguous, and the full name is long.\n\nChange-Id: I1d2e9eb6c7dec0d09ca42b41dc252786d2024a5a\n", "tree_diff": [ { "type": "modify", "old_id": "0d473afcc97b9fe5ebbd6bf020ff0b025553868f", "old_mode": 33188, "old_path": "java/com/google/gerrit/acceptance/DisabledChangeIndex.java", "new_id": "d39edec9371428d83e72244f819da38801ea4bc2", "new_mode": 33188, "new_path": "java/com/google/gerrit/acceptance/DisabledChangeIndex.java" }, { "type": "modify", "old_id": "5209f9065cd7465970fbe57ff46c0f343012b478", "old_mode": 33188, "old_path": "java/com/google/gerrit/acceptance/ReadOnlyChangeIndex.java", "new_id": "d4fd318c64626f8e80840d0f88ee5a3500d61924", "new_mode": 33188, "new_path": "java/com/google/gerrit/acceptance/ReadOnlyChangeIndex.java" }, { "type": "modify", "old_id": "1f2fa683b60e2f110a7776b41718751087457f8f", "old_mode": 33188, "old_path": "java/com/google/gerrit/acceptance/testsuite/project/ProjectOperationsImpl.java", "new_id": "28be3f3a7e9a1b5568822e7e95b1da74e502b18d", "new_mode": 33188, "new_path": "java/com/google/gerrit/acceptance/testsuite/project/ProjectOperationsImpl.java" }, { "type": "modify", "old_id": "cf4022bae5cee434aa7fe6941050562ac0c752b6", "old_mode": 33188, "old_path": "java/com/google/gerrit/elasticsearch/ElasticChangeIndex.java", "new_id": "69dde395f5736f393849c6b78c930ddfc99889f7", "new_mode": 33188, "new_path": "java/com/google/gerrit/elasticsearch/ElasticChangeIndex.java" }, { "type": "modify", "old_id": "2f522a29445257ddc2d5107c328753691e74f943", "old_mode": 33188, "old_path": "java/com/google/gerrit/httpd/raw/ToolServlet.java", "new_id": "0d707a6fd68d4590807dd5131541228523f3daff", "new_mode": 33188, "new_path": "java/com/google/gerrit/httpd/raw/ToolServlet.java" }, { "type": "modify", "old_id": "dcc96d5c13a8e9a6fea41b6f7e73c95e3c0c31c5", "old_mode": 33188, "old_path": "java/com/google/gerrit/server/DynamicOptions.java", "new_id": "11d33360d14fd7a2a28913296fb67faf54a6308a", "new_mode": 33188, "new_path": "java/com/google/gerrit/server/DynamicOptions.java" }, { "type": "modify", "old_id": "25db8d91056f4e5e4828a85b57dfbb0b965213e0", "old_mode": 33188, "old_path": "java/com/google/gerrit/server/PublishCommentUtil.java", "new_id": "75a364ccb29585fb1fff3c669e4c8fe75c850f25", "new_mode": 33188, "new_path": "java/com/google/gerrit/server/PublishCommentUtil.java" }, { "type": "modify", "old_id": "6767b85dec574b9f03f7d48dac42e55fd282b6f3", "old_mode": 33188, "old_path": "java/com/google/gerrit/server/account/Preferences.java", "new_id": "f33d8fe3db4a41e04ae508277d230899765b062b", "new_mode": 33188, "new_path": "java/com/google/gerrit/server/account/Preferences.java" }, { "type": "modify", "old_id": "11442d28a10b16694d40c31609d8e0b41fbc4403", "old_mode": 33188, "old_path": "java/com/google/gerrit/server/change/LabelsJson.java", "new_id": "d76cadc49bd512f418f24bcf0a6278f30b28c648", "new_mode": 33188, "new_path": "java/com/google/gerrit/server/change/LabelsJson.java" }, { "type": "modify", "old_id": "c29faee1d88d77aaf48466880bc2b941fefccd95", "old_mode": 33188, "old_path": "java/com/google/gerrit/server/change/NotifyUtil.java", "new_id": "fa6fdfc8a62b1acf1756950c5cf50cff5c56f72a", "new_mode": 33188, "new_path": "java/com/google/gerrit/server/change/NotifyUtil.java" }, { "type": "modify", "old_id": "b67028da60b52811b1e7d26ce01752a8a8bce4c2", "old_mode": 33188, "old_path": "java/com/google/gerrit/server/change/RevisionJson.java", "new_id": "42175eb5592ff0c192fd57270eea169c9058dcb5", "new_mode": 33188, "new_path": "java/com/google/gerrit/server/change/RevisionJson.java" }, { "type": "modify", "old_id": "faddfe66a032dae4ddea96b86a8df510063168e2", "old_mode": 33188, "old_path": "java/com/google/gerrit/server/events/StreamEventsApiListener.java", "new_id": "750b579099eb9abfd675c237367a39f08da4e478", "new_mode": 33188, "new_path": "java/com/google/gerrit/server/events/StreamEventsApiListener.java" }, { "type": "modify", "old_id": "ee4d71ea2df7afe061ff971285861bf40b83017e", "old_mode": 33188, "old_path": "java/com/google/gerrit/server/git/MergeUtil.java", "new_id": "8599fbe471391d14802e9fba4b56dd590e1190d9", "new_mode": 33188, "new_path": "java/com/google/gerrit/server/git/MergeUtil.java" }, { "type": "modify", "old_id": "abbba86779693566a85999420753002554e3d42f", "old_mode": 33188, "old_path": "java/com/google/gerrit/server/git/receive/AsyncReceiveCommits.java", "new_id": "43d7ffc41d6cd39b7f50bbffa863951a86d9a3a6", "new_mode": 33188, "new_path": "java/com/google/gerrit/server/git/receive/AsyncReceiveCommits.java" }, { "type": "modify", "old_id": "55def631d420917c2c37d09f367485827766df0b", "old_mode": 33188, "old_path": "java/com/google/gerrit/server/git/receive/ReceiveCommits.java", "new_id": "388d13a5c43eac81cd989b8186b65080a56ed67d", "new_mode": 33188, "new_path": "java/com/google/gerrit/server/git/receive/ReceiveCommits.java" }, { "type": "modify", "old_id": "e3dfa75bd233cd856cd720d0117850a6f1938b10", "old_mode": 33188, "old_path": "java/com/google/gerrit/server/git/validators/CommitValidators.java", "new_id": "e3b4c5127dbe84775440d20e1ebe0d38b4254156", "new_mode": 33188, "new_path": "java/com/google/gerrit/server/git/validators/CommitValidators.java" }, { "type": "modify", "old_id": "4b851ea0b8ee901680cfe48dc63b8b75a439721a", "old_mode": 33188, "old_path": "java/com/google/gerrit/server/group/GroupAuditService.java", "new_id": "4c02adaf5f4b7eefd0178eab995a67ee3c0c34be", "new_mode": 33188, "new_path": "java/com/google/gerrit/server/group/GroupAuditService.java" }, { "type": "modify", "old_id": "819c8ac730f81f47f5df0b73803f4bc58a86ef7c", "old_mode": 33188, "old_path": "java/com/google/gerrit/server/notedb/LegacyChangeNoteRead.java", "new_id": "916cc16d79572d6f17b60c6bddc7a2b7c6039178", "new_mode": 33188, "new_path": "java/com/google/gerrit/server/notedb/LegacyChangeNoteRead.java" }, { "type": "modify", "old_id": "592bed8bc2f6d24c0b32127489ad0ca24609fdf2", "old_mode": 33188, "old_path": "java/com/google/gerrit/server/plugins/PluginLoader.java", "new_id": "9279f0fee43276003e376b73667ffb3b62171dee", "new_mode": 33188, "new_path": "java/com/google/gerrit/server/plugins/PluginLoader.java" }, { "type": "modify", "old_id": "f051d109f68521148d56563cf9f4bcd0ca597d19", "old_mode": 33188, "old_path": "java/com/google/gerrit/server/project/ProjectConfig.java", "new_id": "60d9ec6a39a43f6432959de636b92647f8cd2c6c", "new_mode": 33188, "new_path": "java/com/google/gerrit/server/project/ProjectConfig.java" }, { "type": "modify", "old_id": "76ee8c90f9d1d06d426bfd5ffd6427e664f57bc2", "old_mode": 33188, "old_path": "java/com/google/gerrit/server/project/Reachable.java", "new_id": "29340d99d29c12ea1ad1b01419203bf0cb44fd75", "new_mode": 33188, "new_path": "java/com/google/gerrit/server/project/Reachable.java" }, { "type": "modify", "old_id": "c6e67ca1be8c0e9b856c81bfdff0ce501b3fc7b4", "old_mode": 33188, "old_path": "java/com/google/gerrit/server/quota/DefaultQuotaBackend.java", "new_id": "1f4f48c5cae15638924040b6969b75d8185f80eb", "new_mode": 33188, "new_path": "java/com/google/gerrit/server/quota/DefaultQuotaBackend.java" }, { "type": "modify", "old_id": "87564abf644fb8b032be5478443f57cac6a89c7e", "old_mode": 33188, "old_path": "java/com/google/gerrit/server/restapi/account/DeleteDraftComments.java", "new_id": "135718b54a3c385436946e9453cb09f91939a230", "new_mode": 33188, "new_path": "java/com/google/gerrit/server/restapi/account/DeleteDraftComments.java" }, { "type": "modify", "old_id": "eb79b79bfb74a0b013eadab51c9d0fb2c76f0fdb", "old_mode": 33188, "old_path": "java/com/google/gerrit/server/restapi/change/ReviewerRecommender.java", "new_id": "b2cbe80f0fa79d47fde31f8bc997138cb612af87", "new_mode": 33188, "new_path": "java/com/google/gerrit/server/restapi/change/ReviewerRecommender.java" }, { "type": "modify", "old_id": "921a59126eaa68eabd28a7e10636319260404916", "old_mode": 33188, "old_path": "java/com/google/gerrit/server/restapi/project/PutConfig.java", "new_id": "150989be856dfe5d5c5d384a38511cd099994e9e", "new_mode": 33188, "new_path": "java/com/google/gerrit/server/restapi/project/PutConfig.java" }, { "type": "modify", "old_id": "2a2fc866f8a4b20a252f7874b89247eb1acb1bff", "old_mode": 33188, "old_path": "java/com/google/gerrit/server/restapi/project/RepositoryStatistics.java", "new_id": "9f686eb4b7bf8e12f91391135078ca2af81e59db", "new_mode": 33188, "new_path": "java/com/google/gerrit/server/restapi/project/RepositoryStatistics.java" }, { "type": "modify", "old_id": "b3a9a16cc146da915ed088e1267b2ba526ec9b4e", "old_mode": 33188, "old_path": "java/com/google/gerrit/sshd/commands/ScpCommand.java", "new_id": "5122b3503b0c910aba4b95d896f80d7edc93330b", "new_mode": 33188, "new_path": "java/com/google/gerrit/sshd/commands/ScpCommand.java" }, { "type": "modify", "old_id": "e4c14d89c6c7a12ed426c28c10d86e6b3b846290", "old_mode": 33188, "old_path": "java/com/google/gerrit/sshd/commands/ShowCaches.java", "new_id": "be13a84cf4485d1a05f3576edd26392f00dbd500", "new_mode": 33188, "new_path": "java/com/google/gerrit/sshd/commands/ShowCaches.java" }, { "type": "modify", "old_id": "84a0809b28065b7cdd7defd513d847c65e54ddaf", "old_mode": 33188, "old_path": "java/com/google/gerrit/util/cli/OptionHandlers.java", "new_id": "95474101d53036e63ee8fda11e70514b2138d2c1", "new_mode": 33188, "new_path": "java/com/google/gerrit/util/cli/OptionHandlers.java" }, { "type": "modify", "old_id": "0bbe76910f871429d4ead766a20bda6d8cd77152", "old_mode": 33188, "old_path": "javatests/com/google/gerrit/acceptance/git/SubmoduleSubscriptionsWholeTopicMergeIT.java", "new_id": "dc84d13fc653cef7a29fe805b5119b2dbc7d4f31", "new_mode": 33188, "new_path": "javatests/com/google/gerrit/acceptance/git/SubmoduleSubscriptionsWholeTopicMergeIT.java" }, { "type": "modify", "old_id": "237859c1a0175f49648e31c896a94e77f868f1e4", "old_mode": 33188, "old_path": "javatests/com/google/gerrit/acceptance/ssh/SetReviewersIT.java", "new_id": "7b0088e86282e1c8da66ce7a01283decb47e6fa4", "new_mode": 33188, "new_path": "javatests/com/google/gerrit/acceptance/ssh/SetReviewersIT.java" }, { "type": "modify", "old_id": "ef71b6725a9e8ff13d6a21cc358b637ca804ebd8", "old_mode": 33188, "old_path": "javatests/com/google/gerrit/common/data/LabelFunctionTest.java", "new_id": "a534a9e8f8f1a7bbb051e745adefce227ba0ed58", "new_mode": 33188, "new_path": "javatests/com/google/gerrit/common/data/LabelFunctionTest.java" }, { "type": "modify", "old_id": "a4a196b6665dea512b5518f229fb440b910cad38", "old_mode": 33188, "old_path": "javatests/com/google/gerrit/server/config/ListCapabilitiesTest.java", "new_id": "081a2f75b14e88c9ed06bdeb5b3daada5c2a6228", "new_mode": 33188, "new_path": "javatests/com/google/gerrit/server/config/ListCapabilitiesTest.java" }, { "type": "modify", "old_id": "9164fdbfab01e56e3bb7e02067fed33fbc8e3c01", "old_mode": 33188, "old_path": "javatests/com/google/gerrit/server/query/change/AbstractQueryChangesTest.java", "new_id": "fb1ac12c0b41b556ec8b50cf0018f4ea848c73a4", "new_mode": 33188, "new_path": "javatests/com/google/gerrit/server/query/change/AbstractQueryChangesTest.java" }, { "type": "modify", "old_id": "3a470d7b5268dfd3f8c2f95a7e0c493f8fb3629a", "old_mode": 57344, "old_path": "plugins/replication", "new_id": "38fc58bdd9b3c751b0da985e2c17b00dfab3b4fd", "new_mode": 57344, "new_path": "plugins/replication" }, { "type": "modify", "old_id": "48703a1cf5dce6af87f700ccda2c6f5949a6fa1c", "old_mode": 57344, "old_path": "plugins/webhooks", "new_id": "edf3122969d445b65feef2174828e115fb1ceedc", "new_mode": 57344, "new_path": "plugins/webhooks" } ] }