tree 7c1a6224293c023a0396086d9e013c589cdd9863
parent 2c2cf6998094c78a006d3cfa67856e671bb0f4fd
author Dave Borowitz <dborowitz@google.com> 1476911407 -0400
committer David Pursehouse <dpursehouse@collab.net> 1476924670 +0900

GroupList: Do not store null UUIDs

A GroupList is a parsed representation of the groups file, which
cannot contain any null entries. Caching null entries in this class is
not appropriate.

In addition to this theoretical objection, it is definitely incorrect
to return a cached GroupReference with null UUID from #resolve.
ProjectConfig will create a distinct GroupReference with a different
name for each group that is missing in the groups file, and it's not
correct to return a GroupReference from resolve with a different name
from the one that was passed in, even if they both have null UUID.

This commit additionally reverts 26fe49b, since the new implementation
of resolve would just return the input anyway, so the call would be a
no-op.

This reverts commit 26fe49b72f6075fdc36dbdcfbbc5c878cbcd8c14.

Change-Id: I27e4ed5443122557ab3a719b8bdb052a5e373f58