tree c575bb8071a24ad1d30dacd32232f2f18798226e
parent 62d3f7f2af30ee0e1cb79968a51af687d28cbeeb
author Nasser Grainawi <nasser.grainawi@linaro.org> 1712690290 -0600
committer Nasser Grainawi <nasser.grainawi@linaro.org> 1712772144 -0700

Avoid work in Optional.orElse() calls

Any code inside the orElse() will always be called, even if the result
isn't used because the optional is present. This is wasteful at a
minimum and can be actively harmful (as seen in [1]) because of side
effects or performance impacts. Fix that by replacing all orElse() calls
that create new instances or do non-constant work with either a call to
orElseGet() or an if statement.

This change is a follow up to Icab411599 that fixes new instances of
this pattern introduced in stable-3.10.

[1] https://gerrit-review.googlesource.com/c/gerrit/+/417915/comment/0ea287cd_bfecb7f2/

Release-Notes: skip
Change-Id: I0f146b5909020c716cae783787349c05ac765345