)]}'
{
  "commit": "0db323c28d2a716ff9df18b2c306af13cc6973e0",
  "tree": "aea68aac0cb0207499de4fd330c726ed32c901be",
  "parents": [
    "709f6a34aaab68fb7878ac1b1533302c97edbd63"
  ],
  "author": {
    "name": "Luca Milanesio",
    "email": "luca.milanesio@gmail.com",
    "time": "Thu Jul 02 16:05:10 2020 +0100"
  },
  "committer": {
    "name": "Gerrit Code Review",
    "email": "noreply-gerritcodereview@google.com",
    "time": "Thu Jul 02 15:05:10 2020 +0000"
  },
  "message": "Update git submodules\n\n* Update plugins/replication from branch \u0027master\u0027\n  to ced7fc318feb76e2fc6d549669c5f5d8d905add5\n  - Merge branch \u0027stable-3.2\u0027\n    \n    * stable-3.2:\n      Improve readability of shouldFirePendingOnlyToStoredUri test\n      Fix flakiness in ReplicationIT for pending events firing\n      Only fire the specified pending event URI\n    \n    Change-Id: If550f00b22c0cab5bd49a24f13110da65ecded00\n    \n  - Merge branch \u0027stable-3.1\u0027 into stable-3.2\n    \n    * stable-3.1:\n      Improve readability of shouldFirePendingOnlyToStoredUri test\n      Fix flakiness in ReplicationIT for pending events firing\n      Only fire the specified pending event URI\n    \n    Change-Id: Ie83763e4a9fe13522f356b569fc2360fa5883224\n    \n  - Merge branch \u0027stable-3.0\u0027 into stable-3.1\n    \n    * stable-3.0:\n      Improve readability of shouldFirePendingOnlyToStoredUri test\n      Fix flakiness in ReplicationIT for pending events firing\n    \n    Change-Id: I58ce5a03d7b1094ef859c4cd2bd08a3ead00ba30\n    \n  - Merge branch \u0027stable-2.16\u0027 into stable-3.0\n    \n    * stable-2.16:\n      Improve readability of shouldFirePendingOnlyToStoredUri test\n      Fix flakiness in ReplicationIT for pending events firing\n    \n    Change-Id: Id40baca92acc9fba8656630f725d55e5fbb6662b\n    \n  - Improve readability of shouldFirePendingOnlyToStoredUri test\n    \n    Make the ReplicationIT.shouldFirePendingOnlyToStoredUri easier\n    to read and simplify the extraction of the replication tasks\n    associated to a change ref, as regex matching isn\u0027t required\n    and could be misleading when reading the test.\n    \n    Change-Id: Ib493275872b56bc04cdcfb541b7cfa7ecfb1e058\n    \n  - Fix flakiness in ReplicationIT for pending events firing\n    \n    Fix the shouldFirePendingOnlyToStoredUri test by making sure\n    that events are NOT executed by the replication engine until\n    the tests has completed the preparation phase.\n    \n    The Gerrit build on stable-2.16 became flaky right afterward\n    the merge of the new shouldFirePendingOnlyToStoredUri test which\n    highlighted the flakiness.\n    \n    The test wants to simulate a situation where a ref-update needs\n    to be propagated to two remotes: remote1 and remote2.\n    For doing so, it configures the two remotes and crates a change\n    for generating the two replication tasks files on the filesystem.\n    Then, it looks for the events associated for remote1 and removes\n    them, so that the next replication queue startup won\u0027t find it\n    and won\u0027t replicate the change to remote1.\n    \n    During the interval of time between the creation of the change\n    and the removal of the underlying replication task on the filesystem,\n    the replication task could have been executed already and the\n    test failed.\n    \n    Make sure that the replication does not kick in by\n    setting the replication timeout to Integer.MAX_VALUE at the\n    beginning. Then, once the replication task file is removed on the\n    filesystem, set it back to default and reload the configuration to\n    trigger the firing of the events.\n    \n    Remove also the explicit start/stop of the replication queue, as\n    the config reload is already a stop/start process and it\n    automatically triggering an event replay.\n    \n    Change-Id: Ifd591da37e94b6ce8f281cb0404f3f3c737489f3\n    \n  - Merge branch \u0027stable-3.0\u0027 into stable-3.1\n    \n    * stable-3.0:\n      Only fire the specified pending event URI\n    \n    Adapt to the new refactored code of the config\n    and destinations in stable-3.1 and remove unused\n    methods coming from the merge with stable-3.0.\n    \n    Change-Id: Ica9da7c735bbd965bc6704dec35419dba126ab66\n    \n  - Merge branch \u0027stable-2.16\u0027 into stable-3.0\n    \n    * stable-2.16:\n      Only fire the specified pending event URI\n    \n    Change-Id: Ib800603d830c9b4ba688b0222ac5642ad50f17a0\n    \n  - Only fire the specified pending event URI\n    \n    Previously the startup firing of pending events would fire every URI for\n    a project ref combination on startup. To avoid duplicates, it only ever\n    fired one round of every URI per project/ref combination. This had the\n    side effect that if only a single URI were stored, presumably because\n    the other URIs were completed before shutdown, this would result in the\n    creation of way more replication events than necessary, presumably many\n    duplicates of already completed pushes. Fix this behavior by only firing\n    to the specific stored URI, and remove the duplicate project/ref\n    filtering since that now would prevent firing to more than one URI for\n    the same project/ref combination when there actually are stored events\n    for multiple URIs. Add a test to confirm the correct new more limiting\n    behavior.\n    \n    Bug: Issue 12779\n    Change-Id: I56d314af2ecbf84362dda099fa28f1b8f82cefa7\n    ",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "b0ecbd3c88fd0d8b19112e33049564e25ac5fc39",
      "old_mode": 57344,
      "old_path": "plugins/replication",
      "new_id": "ced7fc318feb76e2fc6d549669c5f5d8d905add5",
      "new_mode": 57344,
      "new_path": "plugins/replication"
    }
  ]
}