commit ed45c6bae1cecae200815281c9168ccdc5a23ef3
author Antonio Barone <syntonyze@gmail.com> Mon Mar 08 14:58:41 2021 +0100
committer Antonio Barone <syntonyze@gmail.com> Tue Mar 09 12:35:15 2021 +0000
tree 245ba1b5b3731cfb3214857d6ad85bd3b825c398
parent d020485d8f5336bc1d1e3f19a8bc240c371824c3

Default git http username and password to empty strings

Not having a default for Gerrit http username and password causes
Jenkins to fail due to:

```
IllegalArgumentException: Null value not allowed as an environment
variable
```

Default gerrit http username and password to empty strings and check for
empty values to decide whether to use vault defaults.

Bug: Issue 14194
Change-Id: Ic719dfcde11e00f1bb272b2ff7954dc47fc03e27

jenkins/gatlingTestPipeline.groovy

diff --git a/jenkins/gatlingTestPipeline.groovy b/jenkins/gatlingTestPipeline.groovy
index 27a6c33..6339bcc 100644
--- a/jenkins/gatlingTestPipeline.groovy
+++ b/jenkins/gatlingTestPipeline.groovy
@@ -28,8 +28,8 @@
             string(name: 'GERRIT_SSH_PORT', defaultValue: '29418', description: 'Gerrit SSH port')
 
             string(name: 'GERRIT_HTTP_SCHEMA', defaultValue: 'https', description: 'Gerrit HTTP schema')
-            string(name: 'GIT_HTTP_USERNAME', description: 'Username for Git/HTTP testing, use vault by default')
-            password(name: 'GIT_HTTP_PASSWORD', description: 'Password for Git/HTTP testing, use vault by default')
+            string(name: 'GIT_HTTP_USERNAME', defaultValue: '', description: 'Username for Git/HTTP testing, use vault by default')
+            password(name: 'GIT_HTTP_PASSWORD', defaultValue: '', description: 'Password for Git/HTTP testing, use vault by default')
 
             string(name: 'GERRIT_PROJECT', defaultValue: 'load-test', description: 'Gerrit project for load test')
             string(name: 'NUM_USERS', defaultValue: '10', description: 'Number of concurrent user sessions')
@@ -132,8 +132,8 @@
                             credentialsId: "gatlingHttp")]) {
                         script {
 
-                            def gitHttpUsername = "${params.GIT_HTTP_USERNAME}" ?: "${env.DEFAULT_GIT_HTTP_USERNAME}"
-                            def gitHttpPassword = "${params.GIT_HTTP_PASSWORD}" ?: "${env.DEFAULT_GIT_HTTP_PASSWORD}"
+                            def gitHttpUsername = ("${params.GIT_HTTP_USERNAME}"?.trim()) ?: "${env.DEFAULT_GIT_HTTP_USERNAME}"
+                            def gitHttpPassword = ("${params.GIT_HTTP_PASSWORD}"?.trim()) ?: "${env.DEFAULT_GIT_HTTP_PASSWORD}"
 
                             writeFile(file: "simulation.env", text: """
                                     GERRIT_HTTP_URL=${GERRIT_HTTP_URL}