Google Git
Sign in
gerrit / buck / refs/heads/github-master
commit77bf5a2d31763f8d0909090cc7e376d0b2dd8ff1[log] [tgz]
authorSergey Tyurin <tyurins@fb.com>Fri Jun 14 20:17:33 2019 -0700
committerFacebook Github Bot <facebook-github-bot@users.noreply.github.com>Fri Jun 14 21:20:52 2019 -0700
tree5209763525ac61a2f4786cb6f29ad7b69e6d1790
parentc0e657b285e482ac78bd23fb5c945a3a0a712fac [diff]
Fail IntelliJ project when CL arguments resolves to empty set of targets

Summary:
This logic is not necessary since arguments are checked for being empty at the beginning of `parseTargetsAndRunProjectGenerator`. If arguments are empty it uses `//...` as an input which should return all the targets in the graph.

Checking for empty targets after processing arguments and parsing the whole repository means that Buck would parse the whole repository when input arguments are resolved into empty set of targets which counter-intuitive.

Reviewed By: jtorkkola

shipit-source-id: 6ff99177ff
1 file changed
tree: 5209763525ac61a2f4786cb6f29ad7b69e6d1790
  1. .buckconfig
  2. .buckjavaargs
  3. .buckrelease
  4. .gitattributes
  5. .gitignore
  6. .idea/
  7. .inferconfig
  8. .travis.yml
  9. .watchmanconfig
  10. BUCK
  11. CODE_OF_CONDUCT.md
  12. CONTRIBUTING.md
  13. LICENSE
  14. README.md
  15. android/
  16. appveyor.yml
  17. assets/
  18. bin/
  19. buck-parser-py.iml
  20. buck.iml
  21. build.xml
  22. config/
  23. docs/
  24. jitpack.yml
  25. pmd/
  26. programs/
  27. py/
  28. python-dsl/
  29. scripts/
  30. src-gen/
  31. src/
  32. test/
  33. third-party/
  34. tools/
  35. windows_cxx_support.txt
  36. windows_failures.txt
README.md

Buck

Buck is a build tool. To see what Buck can do for you, check out the documentation at http://buck.build/.

Build Status Build status

Installation

First, clone the Buck repository:

git clone --depth 1 https://github.com/facebook/buck.git
cd buck

Since Buck is used to build Buck, the initial build process involves 2 phases:

1. Bootstrap Buck with ant
git clone --depth 1 https://github.com/facebook/buck.git
cd buck
ant
2. Use bootstrapped version of Buck to build Buck:
./bin/buck build --show-output buck
# output will contain something like
# //programs:buck buck-out/gen/programs/buck.pex
buck-out/gen/programs/buck.pex --help
Prebuilt buck binaries

Pre-built binaries of buck for any buck sha can be downloaded from https://jitpack.io/com/github/facebook/buck/<sha>/buck-<sha>.pex. The very first time a version of buck is requested, it is built via jitpack. As a result, it could take a few minutes for this initial binary to become available. Every subsequent request will just serve the built artifact directly. This functionality is available for any fork of buck as well, so you can fetch https://jitpack.io/com/github/<github-user-or-org>/buck/<sha>/buck-<sha>.pex

Feature Deprecation

Buck tries to move fast with respect to its internals. However, for user facing features (build rules, command line interface, etc), the Buck team tries to have a graceful deprecation process. Note that this generally applies only to documented functionality, or functionality that is less documented, but appears to be in wide use. That process is:

  • An issue is opened on Github suggesting what will be deprecated, and when it will be removed. For larger features that are deprecated, there may be a period when the default is the new setting, and the old behavior may only be used with a configuration change.
  • A change is submitted to Buck that puts the old behavior behind a configuration flag and sets the default to the old behavior. These flags can be found at https://buck.build/concept/buckconfig.html#incompatible.
  • For larger features, a change eventually is put in place that sets the default to the new behavior. e.g. when Skylark becomes the default build file parser.
  • When the removal date is reached, a change is submitted to remove the feature. At this point, the configuration value will still parse, but will not be used by Buck internally.

License

Apache License 2.0