tree 14e1f67339777934bf3c9237586324db6c82102b
parent 3599d0b0ba4ae23f2d2c1378f72c829c7e63c81f
author Michael Bolin <mbolin@fb.com> 1384480770 -0800
committer Michael Bolin <mbolin@fb.com> 1384659365 -0800

Use Java 7 APIs to unzip a file instead of shelling out to `unzip`.

Summary:
Users have been reporting intermittent errors when multiple threads
are unzipping artifacts pulled from cache. Previously, we were
shelling out to `unzip` to do this extraction, but now, we use Java 7
APIs that create the parent directories for each file before
writing the file. We'll have to live with this in the wild and see
whether this is an improvement.

If nothing else, this makes this part of the code work on Windows
instead of only Linux and OS X.

Note that this diff also removes the `filesToExtract` option from `UnzipStep`,
as no one was using it and it was not tested.

Test Plan:
I did a build purely from cache with 12 threads and did not get
any collisions.