commit | 9ed775b3f3b644311517c81c1a0ac6e71298522e | [log] [tgz] |
---|---|---|
author | Nasser Grainawi <nasser.grainawi@linaro.org> | Fri Dec 01 14:27:03 2023 -0700 |
committer | Nasser Grainawi <nasser.grainawi@linaro.org> | Fri Dec 01 17:30:31 2023 -0700 |
tree | 448fc6c8caaba386f3a5a7bc59ca239bda8e0083 | |
parent | 41882840cacf1909646d90b83f661613b51f78ff [diff] |
gerrit_polymer: Update rules_nodejs to match Gerrit 3.5.2+ This updates to 5.1.0 which does have breaking changes for users. See [1] and [2] for background info on the rules_nodejs release. Users of gerrit_polymer should update .bazelversion to at least 5.0.0 and update WORKSPACE files similar to how Gerrit core was updated in Change Iba20c21e9a6. [1] https://github.com/bazelbuild/rules_nodejs/releases/tag/5.0.0 [2] https://github.com/bazelbuild/rules_nodejs/wiki/Migrating-to-5.0 Change-Id: I5170d3d20c7c41a49b62c9f7501d1e209eef7f6a
These build rules are used for building Gerrit Code Review plugins with Bazel. Plugins are compiled as .jar
files containing plugin code and dependencies.
To be able to use the Gerrit rules, you must provide bindings for the plugin API jars. The easiest way to do so is to add the following to your WORKSPACE
file, which will give you default versions for Gerrit plugin API.
git_repository( name = "com_googlesource_gerrit_bazlets", remote = "https://gerrit.googlesource.com/bazlets", commit = "928c928345646ae958b946e9bbdb462f58dd1384", ) load("@com_googlesource_gerrit_bazlets//:gerrit_api.bzl", "gerrit_api") gerrit_api()
The version
parameter allows to override the default API. For release version numbers, make sure to also provide artifacts' SHA1 sums via the plugin_api_sha1
and acceptance_framework_sha1
parameters:
load("@com_googlesource_gerrit_bazlets//:gerrit_api.bzl", "gerrit_api") gerrit_api(version = "3.2.1", plugin_api_sha1 = "47019cf43ef7e6e8d2d5c0aeba0407d23c93699c", acceptance_framework_sha1 = "6252cab6d1f76202e57858fcffb428424e90b128")
If the version ends in -SNAPSHOT
, the jars are consumed from the local Maven repository (~/.m2
) per default assumed to be and the SHA1 sums can be omitted:
load("@com_googlesource_gerrit_bazlets//:gerrit_api.bzl", "gerrit_api") gerrit_api(version = "3.3.0-SNAPSHOT")
Suppose you have the following directory structure for a simple plugin:
[workspace]/ ├── src │ └── main │ ├── java │ └── resources ├── BUILD └── WORKSPACE
To build this plugin, your BUILD
can look like this:
load("//tools/bzl:plugin.bzl", "gerrit_plugin") gerrit_plugin( name = "reviewers", srcs = glob(["src/main/java/**/*.java"]), manifest_entries = [ "Gerrit-PluginName: reviewers", "Gerrit-Module: com.googlesource.gerrit.plugins.reviewers.Module", ], resources = glob(["src/main/**/*"]), )
Now, you can build the Gerrit plugin by running bazel build <plugin>
.
For a real world example, see the reviewers
plugin.
gerrit_plugin(name, srcs, resources, deps, manifest_entries):
<name>.jar
: library containing built plugin jar