| commit | a495d1f4b912eb6ed3101edca58d76a8a1d25a7c | [log] [tgz] |
|---|---|---|
| author | Hector Oswaldo Caballero <hector.caballero@ericsson.com> | Sun Aug 06 08:59:15 2017 -0400 |
| committer | David Pursehouse <dpursehouse@collab.net> | Tue Oct 03 08:54:43 2017 +0000 |
| tree | 55f583e3bd58a2044272813c9bbf546633de203c | |
| parent | a3149518d221613356d458b207900df225448a3a [diff] |
Allow dash in name of junit_tests rule
So far, if the name of the rule contained a dash (hyphen), as in
high-availability plugin for example, the test execution failed with
error message:
bazel-out/local-fastbuild/bin/high-availability_testsTestSuite.java:6:
error: '{' expected
public class high-availability_testsTestSuite {}
^
This is due to the fact that dashes are not valid characters in the name
of a Java class.
Workaround this by replacing any dash with an underscore.
Change-Id: I80fd4c5bcff0d2af6f337636bd942f30d6a521c6
These build rules are used for building Gerrit Code Review plugins with Bazel. Plugins are compiled as .jar files containing plugin code and dependencies.
To be able to use the Gerrit rules, you must provide bindings for the plugin API jars. The easiest way to do so is to add the following to your WORKSPACE file, which will give you default versions for Gerrit plugin API.
git_repository( name = "com_github_davido_bazlets", remote = "https://github.com/davido/bazlets.git", commit = "2ede19cb2d2dd9d04bcb70ffc896439a27e5d50d", ) load("@com_github_davido_bazlets//:gerrit_api.bzl", "gerrit_api")
Another option is to consume snapshot version of gerrit plugin API from local Maven repository (~/.m2). To use the snapshot version special method is provided:
load("@com_googlesource_gerrit_bazlets//:gerrit_api_maven_local.bzl", "gerrit_api_maven_local") gerrit_api_maven_local()
Suppose you have the following directory structure for a simple plugin:
[workspace]/
WORKSPACE
BUILD
src/main/java/
src/main/resources/
[...]
To build this plugin, your BUILD can look like this:
load("//tools/bzl:plugin.bzl", "gerrit_plugin") gerrit_plugin( name = "reviewers", srcs = glob(["src/main/java/**/*.java"]), gwt_module = "com.googlesource.gerrit.plugins.reviewers.ReviewersForm", manifest_entries = [ "Gerrit-PluginName: reviewers", "Gerrit-Module: com.googlesource.gerrit.plugins.reviewers.Module", ], resources = glob(["src/main/**/*"]), )
Now, you can build the Gerrit plugin by running bazel build <plugin>.
For a real world example, see the reviewers plugin.
gerrit_plugin(name, srcs, resources, gwt_module, deps, manifest_entries):
<name>.jar: library containing built plugin jar