Trim potential trailing newlines from secrets

One of the prerequisites for the execution of a recipe is the
creation and storing of secrets in AWS. The documentation instructs to
create files and then run the add_secrets_aws_secrets_manager.sh to
upload their value to AWS.

Depending on how secret files are created however, trailing newlines
might be added at the end of the file, which in turn might create
problems when the secret is retrieved and used.

For example newlines are not allowed when the LDAP secret is quoted,
causing:

```
fatal: Caused by: org.eclipse.jgit.errors.ConfigInvalidException:
Newline in quotes not allowed
```

Improve add_secrets_aws_secrets_manager.sh so that trailing newlines at
the end of the file are stripped before the secret is created in AWS.

Bug: Issue 13353
Change-Id: Id3ab9a2b5edce8f9623c636c76904790c44293b0
1 file changed
tree: d9ea68477dcbe4b8c5bd0b82b0ac10265775e454
  1. .gitignore
  2. Configuration.md
  3. Docker.md
  4. LICENSE
  5. Makefile.common
  6. Prerequisites.md
  7. README.md
  8. Secrets.md
  9. common-templates/
  10. common.env
  11. dual-master/
  12. gerrit/
  13. ldap/
  14. load-test-fleet/
  15. master-slave/
  16. monitoring/
  17. single-master/
README.md

Gerrit AWS Templates

Those are a collection of AWS CloudFormation templates and scripts to deploy Gerrit in AWS.

The aim is to provide some guidelines and example on how to deploy different Gerrit setups in the Cloud using AWS as provider.

Outline

Overview

The goal of Gerrit AWS Templates is to provide fully-functional Gerrit installations to helps users deploying Gerrit on AWS by providing out-of-the-box templates.

With Gerrit AWS Templates, developers and administrator can create a production-ready installation on the cloud in minutes and in a repeatable way, allowing them to focus on fine tuning of the Gerrit configuration to suit the user needs.

The provided CloudFormation templates automate the entire creation and deployment of the infrastructure and the application.

Pre-requisites

To manage your AWS services via command line you will need to install AWS CLI and set it up to point to your account.

To build gerrit and related-components' images Docker

Templates

External services

This is a list of external services that you might need to setup your stack and some suggestions on how to easily create them.

SMTP Server

If you need to setup a SMTP service Amazon Simple Email Service can be used. Details how setup Amazon SES can be found here.

To correctly setup email notifications Gerrit requires ssl protocol on default port 465 to be enabled on SMTP Server. It is possible to setup Gerrit to talk to standard SMTP port 25 but by default all EC2 instances are blocking it. To enable port 25 please follow this link.

LDAP Server

If you need a testing LDAP server you can find details on how to easily create one in the LDAP folder.