tree d9ea68477dcbe4b8c5bd0b82b0ac10265775e454
parent 466e9d2da196fa52b6a4e3628e58e3af7b017713
author Antonio Barone <syntonyze@gmail.com> 1599480173 +0200
committer Antonio Barone <syntonyze@gmail.com> 1599480173 +0200

Trim potential trailing newlines from secrets

One of the prerequisites for the execution of a recipe is the
creation and storing of secrets in AWS. The documentation instructs to
create files and then run the add_secrets_aws_secrets_manager.sh to
upload their value to AWS.

Depending on how secret files are created however, trailing newlines
might be added at the end of the file, which in turn might create
problems when the secret is retrieved and used.

For example newlines are not allowed when the LDAP secret is quoted,
causing:

```
fatal: Caused by: org.eclipse.jgit.errors.ConfigInvalidException:
Newline in quotes not allowed
```

Improve add_secrets_aws_secrets_manager.sh so that trailing newlines at
the end of the file are stripped before the secret is created in AWS.

Bug: Issue 13353
Change-Id: Id3ab9a2b5edce8f9623c636c76904790c44293b0