commit 0a31d50bc7a0047d43216346bbd9e58a90336494
author Edwin Kempin <ekempin@google.com> Wed Apr 13 13:05:53 2016 +0200
committer Edwin Kempin <ekempin@google.com> Wed Apr 13 13:09:34 2016 +0200
tree 9b10401d1b38e395a94c0180a6a69027cc47ff86
parent 80ef12c07cbc41bcfa28d1e20c10fa029c6406ba

Fix warning in menu files: Use 'ifRoom' instead of 'always'

Also assign a lower orderInCategory for the star and ignore actions so
that they are displayed first.

Change-Id: I2e4ae41b7783cd0f3163d9bf222d03b882a59d3a
Signed-off-by: Edwin Kempin <ekempin@google.com>

app/src/main/res/menu/menu_detailed_change.xml

diff --git a/app/src/main/res/menu/menu_detailed_change.xml b/app/src/main/res/menu/menu_detailed_change.xml
index 3e930fc..da4d0ba 100644
--- a/app/src/main/res/menu/menu_detailed_change.xml
+++ b/app/src/main/res/menu/menu_detailed_change.xml
@@ -18,22 +18,22 @@
       tools:context=".DetailedChangeFragment">
   <item
     android:id="@+id/action_ignore"
-    android:orderInCategory="100"
+    android:orderInCategory="90"
     android:title="@string/action_ignore"
     android:icon="@drawable/ic_visibility_off_white_18dp"
-    app:showAsAction="always"/>
+    app:showAsAction="ifRoom"/>
   <item
     android:id="@+id/action_skip"
     android:orderInCategory="100"
     android:title="@string/action_skip"
     android:icon="@drawable/ic_fast_forward_white_18dp"
-    app:showAsAction="always"/>
+    app:showAsAction="ifRoom"/>
   <item
     android:id="@+id/action_star"
-    android:orderInCategory="100"
+    android:orderInCategory="90"
     android:title="@string/action_star"
     android:icon="@drawable/ic_star_white_16dp"
-    app:showAsAction="always"/>
+    app:showAsAction="ifRoom"/>
   <item
     android:id="@+id/action_add_reviewer"
     android:orderInCategory="100"

app/src/main/res/menu/menu_sort_changes.xml

diff --git a/app/src/main/res/menu/menu_sort_changes.xml b/app/src/main/res/menu/menu_sort_changes.xml
index cb5d24b..6e57e24 100644
--- a/app/src/main/res/menu/menu_sort_changes.xml
+++ b/app/src/main/res/menu/menu_sort_changes.xml
@@ -19,13 +19,13 @@
     android:orderInCategory="100"
     android:title="@string/action_undo"
     android:icon="@drawable/ic_restore_white_18dp"
-    app:showAsAction="always"/>
+    app:showAsAction="ifRoom"/>
   <item
     android:id="@+id/action_reload_change"
     android:orderInCategory="100"
     android:title="@string/action_reload_change"
     android:icon="@drawable/ic_refresh_white_18dp"
-    app:showAsAction="always"/>
+    app:showAsAction="ifRoom"/>
   <item
     android:id="@+id/action_add_reviewer"
     android:orderInCategory="100"