| commit | e0f47a1467be93a896601b927ab1ba45d34808ce | [log] [tgz] |
|---|---|---|
| author | Luca Milanesio <luca.milanesio@gmail.com> | Thu Oct 20 19:53:24 2022 +0100 |
| committer | Luca Milanesio <luca.milanesio@gmail.com> | Fri Oct 21 10:31:26 2022 +0100 |
| tree | 2498def821810ddfa517f3c2db91de60f3876f00 | |
| parent | 03a429d8bce90bcba4134b18dad0837d26d43ba2 [diff] |
Lookup existing changes by exact Change-Id string in ReceiveCommits When processing the refs/for/* magic branch in ReceiveCommits the matching by Change-Id needs to be exact and not by simple query substring matching. Using a substring matching allows having the same change with multiple patch sets having different Change-Ids, which would eventually, create inconsistencies in the whole repository. Example: T0: Push a change 1 with Change-Id=foobar T1: Amend the change 1 with Change-Id=fooba (still matches foobar) T2: Push a change 2 with Change-Id=foobaa After T2, the change 1 amended at T1 would be inconsistent because his Change-Id matches two different changes (1 and 2). In order to enable this specific test-case, the PushOneCommit is able to recognise that the message already contains a Change-Id footer and avoids generating a new one. Also fix in RevisionIT the assumption that including an existing Change-Id was always creating a new commit. In PushOneCommit.java:267 we now assume that specifying an existing Change-Id in the commit message instead of leaving the generation of a new one, means that we are simulating the amending of the existing commit. Effectively, the Change-Id is present in the commit message only when editing an existing change. Previously that behaviour was hidden in deep into the TestRepository and therefore out of our control. Bug: Issue 15664 Release-Notes: Disallow truncating the Change-Id across patch-sets Change-Id: Id685e846d63902d065353ab8d42315367b43d3aa
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update && apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.